Re: [PATCH] c++: Fix call to push_tinst_level during satisfaction [PR99214]

2021-02-25 Thread Patrick Palka via Gcc-patches
On Thu, 25 Feb 2021, Jason Merrill wrote: > On 2/25/21 1:37 AM, Patrick Palka wrote: > > In-Reply-To: <20210225063712.3725111-1-ppa...@redhat.com> > > BTW, This patch doesn't seem in any way a reply to your previous patch, so > it's confusing for the mail headers (and thus MUA threading) to say t

Re: [PATCH] c++: Fix call to push_tinst_level during satisfaction [PR99214]

2021-02-25 Thread Jason Merrill via Gcc-patches
On 2/25/21 1:37 AM, Patrick Palka wrote: In-Reply-To: <20210225063712.3725111-1-ppa...@redhat.com> BTW, This patch doesn't seem in any way a reply to your previous patch, so it's confusing for the mail headers (and thus MUA threading) to say that it is. Maybe you want git send-email --no-thr

[PATCH] c++: Fix call to push_tinst_level during satisfaction [PR99214]

2021-02-24 Thread Patrick Palka via Gcc-patches
In the three-parameter version of satisfy_declaration_constraints, when 't' isn't the most general template, then 't' doesn't correspond with the augmented template arguments 'args', and so the instantiation context that we push via push_tinst_level isn't quite correct. This manifests as misleadin