Re: [PATCH] c++: Fix ABI issue with alignas on armv7hl [PR94050]

2020-03-07 Thread Jason Merrill
On 3/7/20 6:02 PM, Marek Polacek wrote: On Sat, Mar 07, 2020 at 01:21:41AM -0500, Jason Merrill wrote: On 3/6/20 8:12 PM, Marek Polacek wrote: On Fri, Mar 06, 2020 at 05:49:07PM -0500, Jason Merrill wrote: On 3/5/20 2:40 PM, Marek Polacek wrote: The static_assert in the following test was fai

Re: [PATCH] c++: Fix ABI issue with alignas on armv7hl [PR94050]

2020-03-07 Thread Marek Polacek
On Sat, Mar 07, 2020 at 01:21:41AM -0500, Jason Merrill wrote: > On 3/6/20 8:12 PM, Marek Polacek wrote: > > On Fri, Mar 06, 2020 at 05:49:07PM -0500, Jason Merrill wrote: > > > On 3/5/20 2:40 PM, Marek Polacek wrote: > > > > The static_assert in the following test was failing on armv7hl because >

Re: [PATCH] c++: Fix ABI issue with alignas on armv7hl [PR94050]

2020-03-06 Thread Jason Merrill
On 3/6/20 8:12 PM, Marek Polacek wrote: On Fri, Mar 06, 2020 at 05:49:07PM -0500, Jason Merrill wrote: On 3/5/20 2:40 PM, Marek Polacek wrote: The static_assert in the following test was failing on armv7hl because we were disregarding the alignas specifier on Cell. BaseShape's data takes up 20

Re: [PATCH] c++: Fix ABI issue with alignas on armv7hl [PR94050]

2020-03-06 Thread Marek Polacek
On Fri, Mar 06, 2020 at 05:49:07PM -0500, Jason Merrill wrote: > On 3/5/20 2:40 PM, Marek Polacek wrote: > > The static_assert in the following test was failing on armv7hl because > > we were disregarding the alignas specifier on Cell. BaseShape's data > > takes up 20B on 32-bit architectures, but

Re: [PATCH] c++: Fix ABI issue with alignas on armv7hl [PR94050]

2020-03-06 Thread Jason Merrill
On 3/5/20 2:40 PM, Marek Polacek wrote: The static_assert in the following test was failing on armv7hl because we were disregarding the alignas specifier on Cell. BaseShape's data takes up 20B on 32-bit architectures, but we failed to round up its TYPE_SIZE. This happens since the

Re: [PATCH] c++: Fix ABI issue with alignas on armv7hl [PR94050]

2020-03-06 Thread Jakub Jelinek
On Thu, Mar 05, 2020 at 02:40:16PM -0500, Marek Polacek wrote: > Bootstrapped/regtested on x86_64-linux, ok for trunk? I verified the > fix on the attached testcase using a --target=armv7hl-linux-gnueabi cross, > but haven't actually run the testsuite. FYI, also successfully bootstrapped/regteste

[PATCH] c++: Fix ABI issue with alignas on armv7hl [PR94050]

2020-03-05 Thread Marek Polacek
The static_assert in the following test was failing on armv7hl because we were disregarding the alignas specifier on Cell. BaseShape's data takes up 20B on 32-bit architectures, but we failed to round up its TYPE_SIZE. This happens since the