Re: [PATCH] c++: Allow -Wvirtual-move-assign to be more easily ignored

2025-05-13 Thread Jason Merrill
On 5/13/25 5:18 PM, Owen Avery wrote: This patch makes it easier to selectively disable -Wvirtual-move-assign by allowing diagnostic pragmas on base class move assignment operators to suppress such warnings. Pushed, thanks! gcc/cp/ChangeLog: * method.cc (synthesized_method_walk): Che

[PATCH] c++: Allow -Wvirtual-move-assign to be more easily ignored

2025-05-13 Thread Owen Avery
This patch makes it easier to selectively disable -Wvirtual-move-assign by allowing diagnostic pragmas on base class move assignment operators to suppress such warnings. gcc/cp/ChangeLog: * method.cc (synthesized_method_walk): Check whether -Wvirtual-move-assign is enabled at the

Re: [PATCH] c++: Allow -Wvirtual-move-assign to be more easily ignored

2025-05-13 Thread Jason Merrill
On 5/12/25 5:03 PM, Owen Avery wrote: Please add a little rationale for the change here, perhaps adapting the one from your previous patch. gcc/cp/ChangeLog: * method.cc (synthesized_method_walk): Check whether -Wvirtual-move-assign The (function) should usually go on the s

[PATCH] c++: Allow -Wvirtual-move-assign to be more easily ignored

2025-05-12 Thread Owen Avery
gcc/cp/ChangeLog: * method.cc (synthesized_method_walk): Check whether -Wvirtual-move-assign is enabled at the location of a base class's move assignment operator. gcc/testsuite/ChangeLog: * g++.dg/warn/ignore-virtual-move-assign.C: New test. Co-authored-