Re: [PATCH] c++/78765

2017-01-04 Thread Jason Merrill
OK. Jason On Wed, Jan 4, 2017 at 11:44 AM, Nathan Sidwell wrote: > On 01/04/2017 10:13 AM, Jason Merrill wrote: > >> OK, that looks like the problem; we shouldn't be calling >> maybe_constant_value before we perform the conversion. > > > Yup, that worked. > > > ok? > > nathan > > > -- > Nathan S

Re: [PATCH] c++/78765

2017-01-04 Thread Nathan Sidwell
On 01/04/2017 10:13 AM, Jason Merrill wrote: OK, that looks like the problem; we shouldn't be calling maybe_constant_value before we perform the conversion. Yup, that worked. ok? nathan -- Nathan Sidwell 2017-01-04 Nathan Sidwell cp/ PR c++/78765 * pt.c (convert_nontype_argument): D

Re: [PATCH] c++/78765

2017-01-04 Thread Jason Merrill
On Wed, Jan 4, 2017 at 9:33 AM, Nathan Sidwell wrote: > On 01/04/2017 12:40 AM, Jason Merrill wrote: >> On 12/16/2016 07:23 AM, Nathan Sidwell wrote: >>> >>> when cxx_eval_constant_expression finds a nonconstant expression it >>> returns a TREE without TREE_CONSTANT set. >>> else if (non_constan

Re: [PATCH] c++/78765

2017-01-04 Thread Nathan Sidwell
On 01/04/2017 12:40 AM, Jason Merrill wrote: On 12/16/2016 07:23 AM, Nathan Sidwell wrote: when cxx_eval_constant_expression finds a nonconstant expression it returns a TREE without TREE_CONSTANT set. else if (non_constant_p && TREE_CONSTANT (r)) { /* This isn't actually constant, so u

Re: [PATCH] c++/78765

2017-01-03 Thread Jason Merrill
On 12/16/2016 07:23 AM, Nathan Sidwell wrote: when cxx_eval_constant_expression finds a nonconstant expression it returns a TREE without TREE_CONSTANT set. else if (non_constant_p && TREE_CONSTANT (r)) { /* This isn't actually constant, so unset TREE_CONSTANT. */ ... else //

[PATCH] c++/78765

2016-12-16 Thread Nathan Sidwell
Jason, this patch fixes an ICE that happens after error recovery of a constexpr object that has a bad initializer. your patch introduced this regression: * tree.c (obvalue_p): Rename from lvalue_p. (lvalue_p): Define for c-common. * call.c, cp-tree.h, cvt.c, init.c: Adjust.