Re: [PATCH] c++,coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-30 Thread Jason Merrill via Gcc-patches
or trunk? thanks Iain === [PATCH] c++,coroutines: Stabilize names of promoted slot vars [PR101118]. When we need to 'promote' a value (i.e. store it in the coroutine frame) it is given a frame entry name. This was based on the DECL_UID for slot vars. However, when LTO is used, the name

Re: [PATCH] c++,coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-30 Thread Iain Sandoe
atic counter? That’s a good idea (the only slightly weird effect is that the count does not start at 0, because we’ve added one or more entries by the time we get to produce a name, but that does not affect functionality). re-tested on x86_64-darwin21, as below, OK for trunk? thanks Iain ===

Re: [PATCH] c++,coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-29 Thread Jason Merrill via Gcc-patches
On 3/26/23 12:54, Iain Sandoe wrote: Tested on x86_64-darwin21, x86-64-linux-gnu OK for trunk? Iain When we need to 'promote' a value (i.e. store it in the coroutine frame) it is given a frame entry name. This was based on the DECL_UID for slot vars. However, when LTO is used, the names from mu

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-28 Thread Richard Biener via Gcc-patches
On Tue, Mar 28, 2023 at 1:16 PM Iain Sandoe wrote: > > Hi Richard > > > On 28 Mar 2023, at 12:27, Iain Sandoe wrote: > >> On 28 Mar 2023, at 11:58, Richard Biener > >> wrote: > >> > >> On Mon, Mar 27, 2023 at 9:32 AM Iain Sandoe wrote: > >>> > On 27 Mar 2023, at 12:48, Richard Biener >

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-28 Thread Iain Sandoe
Hi Richard > On 28 Mar 2023, at 12:27, Iain Sandoe wrote: >> On 28 Mar 2023, at 11:58, Richard Biener wrote: >> >> On Mon, Mar 27, 2023 at 9:32 AM Iain Sandoe wrote: >>> On 27 Mar 2023, at 12:48, Richard Biener wrote: On Mon, Mar 27, 2023 at 8:58 AM Iain Sandoe wrote:

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-27 Thread Iain Sandoe
Hi Richard, > On 28 Mar 2023, at 11:58, Richard Biener wrote: > > On Mon, Mar 27, 2023 at 9:32 AM Iain Sandoe wrote: >> >> Hi Richard >> >>> On 27 Mar 2023, at 12:48, Richard Biener wrote: >>> >>> On Mon, Mar 27, 2023 at 8:58 AM Iain Sandoe wrote: Hi Richard, (I’m away from

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-27 Thread Richard Biener via Gcc-patches
On Mon, Mar 27, 2023 at 9:32 AM Iain Sandoe wrote: > > Hi Richard > > > On 27 Mar 2023, at 12:48, Richard Biener wrote: > > > > On Mon, Mar 27, 2023 at 8:58 AM Iain Sandoe wrote: > >> > >> Hi Richard, > >> (I’m away from my usual infrastructure, so responses could be slow and > >> testing thing

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-27 Thread Iain Sandoe
Hi Richard > On 27 Mar 2023, at 12:48, Richard Biener wrote: > > On Mon, Mar 27, 2023 at 8:58 AM Iain Sandoe wrote: >> >> Hi Richard, >> (I’m away from my usual infrastructure, so responses could be slow and >> testing things >> could take a while). >> >>> On 27 Mar 2023, at 12:10, Richard B

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-27 Thread Richard Biener via Gcc-patches
On Mon, Mar 27, 2023 at 8:58 AM Iain Sandoe wrote: > > Hi Richard, > (I’m away from my usual infrastructure, so responses could be slow and > testing things > could take a while). > > > On 27 Mar 2023, at 12:10, Richard Biener wrote: > > > > On Sun, Mar 26, 2023 at 6:55 PM Iain Sandoe via Gcc-pa

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-26 Thread Iain Sandoe
Hi Richard, (I’m away from my usual infrastructure, so responses could be slow and testing things could take a while). > On 27 Mar 2023, at 12:10, Richard Biener wrote: > > On Sun, Mar 26, 2023 at 6:55 PM Iain Sandoe via Gcc-patches > wrote: >> >> Tested on x86_64-darwin21, x86-64-linux-gnu >

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-26 Thread Richard Biener via Gcc-patches
On Sun, Mar 26, 2023 at 6:55 PM Iain Sandoe via Gcc-patches wrote: > > Tested on x86_64-darwin21, x86-64-linux-gnu > OK for trunk? > Iain > > When we need to 'promote' a value (i.e. store it in the coroutine frame) it > is given a frame entry name. This was based on the DECL_UID for slot vars. >

[PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-26 Thread Iain Sandoe via Gcc-patches
Tested on x86_64-darwin21, x86-64-linux-gnu OK for trunk? Iain When we need to 'promote' a value (i.e. store it in the coroutine frame) it is given a frame entry name. This was based on the DECL_UID for slot vars. However, when LTO is used, the names from multiple TUs become visible at the same t