Re: [PATCH] c++, coroutines: Fix awaiter var creation [PR116506].

2024-09-17 Thread Jason Merrill
On 9/17/24 9:26 PM, Iain Sandoe wrote: On 17 Sep 2024, at 20:06, Jason Merrill wrote: On 9/17/24 8:26 PM, Iain Sandoe wrote: On 17 Sep 2024, at 18:24, Jason Merrill wrote: On 8/29/24 5:22 PM, Iain Sandoe wrote: Tested on x86_64-darwin/linux, powerpc64le linux, OK for trunk? thanks, Iain

Re: [PATCH] c++, coroutines: Fix awaiter var creation [PR116506].

2024-09-17 Thread Iain Sandoe
> On 17 Sep 2024, at 20:06, Jason Merrill wrote: > > On 9/17/24 8:26 PM, Iain Sandoe wrote: >>> On 17 Sep 2024, at 18:24, Jason Merrill wrote: >>> >>> On 8/29/24 5:22 PM, Iain Sandoe wrote: Tested on x86_64-darwin/linux, powerpc64le linux, OK for trunk? thanks, Iain --- >

Re: [PATCH] c++, coroutines: Fix awaiter var creation [PR116506].

2024-09-17 Thread Jason Merrill
On 9/17/24 8:26 PM, Iain Sandoe wrote: On 17 Sep 2024, at 18:24, Jason Merrill wrote: On 8/29/24 5:22 PM, Iain Sandoe wrote: Tested on x86_64-darwin/linux, powerpc64le linux, OK for trunk? thanks, Iain --- >8 --- Awaiters always need to have a coroutine state frame copy since they persist a

Re: [PATCH] c++, coroutines: Fix awaiter var creation [PR116506].

2024-09-17 Thread Iain Sandoe
> On 17 Sep 2024, at 18:24, Jason Merrill wrote: > > On 8/29/24 5:22 PM, Iain Sandoe wrote: >> Tested on x86_64-darwin/linux, powerpc64le linux, OK for trunk? >> thanks, >> Iain >> --- >8 --- >> Awaiters always need to have a coroutine state frame copy since >> they persist across potential su

Re: [PATCH] c++, coroutines: Fix awaiter var creation [PR116506].

2024-09-17 Thread Jason Merrill
On 8/29/24 5:22 PM, Iain Sandoe wrote: Tested on x86_64-darwin/linux, powerpc64le linux, OK for trunk? thanks, Iain --- >8 --- Awaiters always need to have a coroutine state frame copy since they persist across potential supensions. It simplifies the later analysis considerably to assign these

[ping] Re: [PATCH] c++, coroutines: Fix awaiter var creation [PR116506].

2024-09-17 Thread Iain Sandoe
Hi Jason, gentle ping for this one > On 29 Aug 2024, at 16:22, Iain Sandoe wrote: > > Tested on x86_64-darwin/linux, powerpc64le linux, OK for trunk? > thanks, > Iain > > --- >8 --- > > Awaiters always need to have a coroutine state frame copy since > they persist across potential supensions.

[PATCH] c++, coroutines: Fix awaiter var creation [PR116506].

2024-08-29 Thread Iain Sandoe
Tested on x86_64-darwin/linux, powerpc64le linux, OK for trunk? thanks, Iain --- >8 --- Awaiters always need to have a coroutine state frame copy since they persist across potential supensions. It simplifies the later analysis considerably to assign these early which we do when building co_await