Re: [PATCH] Warn for ignored ASM labels on typdef declarations PR 85444 (v.3)

2018-05-31 Thread Joseph Myers
On Sat, 26 May 2018, Will Hawkins wrote: > > + if (asmspec_tree != NULL_TREE) > > +{ > > + warning (OPT_Wignored_asm_name, "asm-specifier is ignored in " > > + "typedef declaration"); > > +} We avoid braces around a single statement like this. I don't think diagnostic

Re: [PATCH] Warn for ignored ASM labels on typdef declarations PR 85444 (v.3)

2018-05-26 Thread Will Hawkins
Hello everyone! I know every member of the community is very busy, but I am following up on this patch to conform to the 'ping' etiquette. Please let me know what comments you have about this patch and how I can modify it to make sure that it meets standards. Thanks for everything that you all d

Re: [PATCH] Warn for ignored ASM labels on typdef declarations PR 85444 (v.3)

2018-05-18 Thread Will Hawkins
Hello again! Thanks to the feedback of Mr. Myers and those on the PR, I have created a version 3 of this patch. This version introduces a new warning flag (enabled at Wall) -Wignored-asm-name that will flag cases where the user specifies an ASM name that the compiler ignores. Test cases included.