Re: [PATCH] Use __BYTE_ORDER__ predefined macro instead of runtime check

2017-11-22 Thread Janne Blomqvist
On Wed, Nov 22, 2017 at 8:16 PM, Thomas Koenig wrote: > Hi janne, > >> Regtested on x86_64-pc-linux-gnu, Ok for trunk? > > > Jerry already OK'd this, so you can commit if you want. > What you could do is to hide the macro invocation behind > a macro in libgfortran.h, something like > > #define BIG

Re: [PATCH] Use __BYTE_ORDER__ predefined macro instead of runtime check

2017-11-22 Thread Andreas Schwab
On Nov 22 2017, Thomas Koenig wrote: > Jerry already OK'd this, so you can commit if you want. > What you could do is to hide the macro invocation behind > a macro in libgfortran.h, something like > > #define BIG_ENDIAN (__BYTE_ORDER__ == __ORDER_BIG_ENDIAN__) That can easily be confused with th

Re: [PATCH] Use __BYTE_ORDER__ predefined macro instead of runtime check

2017-11-22 Thread Thomas Koenig
Hi janne, Regtested on x86_64-pc-linux-gnu, Ok for trunk? Jerry already OK'd this, so you can commit if you want. What you could do is to hide the macro invocation behind a macro in libgfortran.h, something like #define BIG_ENDIAN (__BYTE_ORDER__ == __ORDER_BIG_ENDIAN__) Also, I have opened

Re: [PATCH] Use __BYTE_ORDER__ predefined macro instead of runtime check

2017-11-22 Thread Jerry DeLisle
On 11/22/2017 04:34 AM, Janne Blomqvist wrote: > By using the __BYTE_ORDER__ predefined macro we don't need the > determine_endianness function anymore. > > Regtested on x86_64-pc-linux-gnu, Ok for trunk? > Looks good, thanks for patch! Jerry

[PATCH] Use __BYTE_ORDER__ predefined macro instead of runtime check

2017-11-22 Thread Janne Blomqvist
By using the __BYTE_ORDER__ predefined macro we don't need the determine_endianness function anymore. Regtested on x86_64-pc-linux-gnu, Ok for trunk? libgfortran/ChangeLog: 2017-11-22 Janne Blomqvist * io/inquire.c (inquire_via_unit): Use __BYTE_ORDER__ predefined macro.