Re: [PATCH] Turn some compile-time tests into run-time tests

2016-04-28 Thread Jeff Law
On 04/28/2016 08:03 AM, Patrick Palka wrote: The rest seem OK to me. Note that I'm not convinced all these tests were designed to be execution tests, even though they use __builtin_abort and friends. Though it's a good marker of something that can/should be looked at. True.. What made me l

Re: [PATCH] Turn some compile-time tests into run-time tests

2016-04-28 Thread Patrick Palka
On Wed, Apr 27, 2016 at 5:36 PM, Jeff Law wrote: > On 03/10/2016 04:38 PM, Patrick Palka wrote: >> >> I ran the command >> >> git grep -l "dg-do compile" | xargs grep -l __builtin_abort | xargs grep >> -lw main >> >> to find tests marked as compile-time tests that likely ought to instead >> be m

Re: [PATCH] Turn some compile-time tests into run-time tests

2016-04-27 Thread Jeff Law
On 03/10/2016 04:38 PM, Patrick Palka wrote: I ran the command git grep -l "dg-do compile" | xargs grep -l __builtin_abort | xargs grep -lw main to find tests marked as compile-time tests that likely ought to instead be marked as run-time tests, by the rationale that they use __builtin_abort

Re: [PATCH] Turn some compile-time tests into run-time tests

2016-04-27 Thread Jeff Law
On 03/11/2016 09:38 AM, Patrick Palka wrote: On Thu, Mar 10, 2016 at 6:38 PM, Patrick Palka wrote: I ran the command git grep -l "dg-do compile" | xargs grep -l __builtin_abort | xargs grep -lw main to find tests marked as compile-time tests that likely ought to instead be marked as run-ti

Re: [PATCH] Turn some compile-time tests into run-time tests

2016-03-11 Thread Patrick Palka
On Thu, Mar 10, 2016 at 6:38 PM, Patrick Palka wrote: > I ran the command > > git grep -l "dg-do compile" | xargs grep -l __builtin_abort | xargs grep > -lw main > > to find tests marked as compile-time tests that likely ought to instead > be marked as run-time tests, by the rationale that they

Re: [PATCH] Turn some compile-time tests into run-time tests

2016-03-10 Thread Patrick Palka
On Thu, Mar 10, 2016 at 6:38 PM, Patrick Palka wrote: > I ran the command > > git grep -l "dg-do compile" | xargs grep -l __builtin_abort | xargs grep > -lw main > > to find tests marked as compile-time tests that likely ought to instead > be marked as run-time tests, by the rationale that they

[PATCH] Turn some compile-time tests into run-time tests

2016-03-10 Thread Patrick Palka
I ran the command git grep -l "dg-do compile" | xargs grep -l __builtin_abort | xargs grep -lw main to find tests marked as compile-time tests that likely ought to instead be marked as run-time tests, by the rationale that they use __builtin_abort and they also define main(). (I also then con