Re: [PATCH] Support dumping type bindings and 'mutable' qualifier in lambda diagnostics.

2013-08-29 Thread Gabriel Dos Reis
On Thu, Aug 29, 2013 at 1:51 PM, Adam Butcher wrote: > * error.c (dump_lambda_function): New function, dependent on ... > (maybe_dump_with_clause): ... this new function, factored out of ... > (subst_to_string): ... here and ... > (dump_function_decl): ... here. Up

Re: [PATCH] Support dumping type bindings and 'mutable' qualifier in lambda diagnostics.

2013-08-29 Thread Adam Butcher
* error.c (dump_lambda_function): New function, dependent on ... (maybe_dump_with_clause): ... this new function, factored out of ... (subst_to_string): ... here and ... (dump_function_decl): ... here. Updated to early-out with call to dump_lambda_function a

Re: [PATCH] Support dumping type bindings and 'mutable' qualifier in lambda diagnostics.

2013-08-29 Thread Adam Butcher
On 29.08.2013 16:25, Gabriel Dos Reis wrote: On Thu, Aug 29, 2013 at 9:20 AM, Adam Butcher wrote: * error.c (dump_lambda_function): New function, dependent on ... (maybe_dump_template_bindings): ... this new function, factored out of ... (dump_function_decl): .

Re: [PATCH] Support dumping type bindings and 'mutable' qualifier in lambda diagnostics.

2013-08-29 Thread Gabriel Dos Reis
On Thu, Aug 29, 2013 at 9:20 AM, Adam Butcher wrote: > * error.c (dump_lambda_function): New function, dependent on ... > (maybe_dump_template_bindings): ... this new function, factored out of > ... > (dump_function_decl): ... here. Updated to early-out with call t

[PATCH] Support dumping type bindings and 'mutable' qualifier in lambda diagnostics.

2013-08-29 Thread Adam Butcher
* error.c (dump_lambda_function): New function, dependent on ... (maybe_dump_template_bindings): ... this new function, factored out of ... (dump_function_decl): ... here. Updated to early-out with call to dump_lambda_function after determining template bind

Re: [PATCH] Support dumping type bindings and 'mutable' qualifier in lambda diagnostics.

2013-08-28 Thread Gabriel Dos Reis
On Tue, Aug 27, 2013 at 7:54 PM, Adam Butcher wrote: > * error.c (dump_function_decl): Use standard diagnostic flow to dump a > lambda diagnostic, albeit without stating the function name or > duplicating the parameter spec (which is dumped as part of the type). > R

[PATCH] Support dumping type bindings and 'mutable' qualifier in lambda diagnostics.

2013-08-28 Thread Adam Butcher
* error.c (dump_function_decl): Use standard diagnostic flow to dump a lambda diagnostic, albeit without stating the function name or duplicating the parameter spec (which is dumped as part of the type). Rather than qualifying the diagnostic with 'const' for plain la