Re: [PATCH] Stream memory access types in IPA ICF.

2019-11-29 Thread Richard Biener
On Fri, Nov 29, 2019 at 2:02 PM Richard Biener wrote: > > On Fri, Nov 29, 2019 at 1:57 PM Jan Hubicka wrote: > > > > Hi, > > this is an example (I just copied first few comparsions on libxul > > builds) > > The operators== seems all instances of nsCOMPtr. > > nsCOMPtr::operator=(nsCOMPtr&&) > > O

Re: [PATCH] Stream memory access types in IPA ICF.

2019-11-29 Thread Jan Hubicka
> On Fri, Nov 29, 2019 at 1:33 PM Jan Hubicka wrote: > > > > > > It looks like a hack. First of all you do quite some useless work since > > > > already the caller of walk_stmt_* could check for the vector length. > > > > second you are streaming a quite random type here with not much > > > > sem

Re: [PATCH] Stream memory access types in IPA ICF.

2019-11-29 Thread Richard Biener
On Fri, Nov 29, 2019 at 1:33 PM Jan Hubicka wrote: > > > > It looks like a hack. First of all you do quite some useless work since > > > already the caller of walk_stmt_* could check for the vector length. > > > second you are streaming a quite random type here with not much > > > semantic value,

Re: [PATCH] Stream memory access types in IPA ICF.

2019-11-29 Thread Jan Hubicka
> > It looks like a hack. First of all you do quite some useless work since > > already the caller of walk_stmt_* could check for the vector length. > > second you are streaming a quite random type here with not much > > semantic value, plus 't' is already the base of the memory reference. > > > >

Re: [PATCH] Stream memory access types in IPA ICF.

2019-11-29 Thread Richard Biener
On Fri, Nov 29, 2019 at 1:17 PM Richard Biener wrote: > > On Fri, Nov 29, 2019 at 12:37 PM Martin Liška wrote: > > > > Hello. > > > > The patch is about streaming of at maximum 3 tree types that are > > used for memory references in IPA ICF. That helps rapidly to reduce > > number of function bod

Re: [PATCH] Stream memory access types in IPA ICF.

2019-11-29 Thread Richard Biener
On Fri, Nov 29, 2019 at 12:37 PM Martin Liška wrote: > > Hello. > > The patch is about streaming of at maximum 3 tree types that are > used for memory references in IPA ICF. That helps rapidly to reduce > number of function bodies loaded in WPA phase. Based on numbers for > Firefox we get from: >

[PATCH] Stream memory access types in IPA ICF.

2019-11-29 Thread Martin Liška
Hello. The patch is about streaming of at maximum 3 tree types that are used for memory references in IPA ICF. That helps rapidly to reduce number of function bodies loaded in WPA phase. Based on numbers for Firefox we get from: Init called for 87557 items (23.30%). ... Totally needed symbols: 4