Re: [PATCH] Some more translation related tweaks

2017-03-01 Thread Jakub Jelinek
On Wed, Mar 01, 2017 at 11:20:37AM +0100, Tom de Vries wrote: > > 2017-02-27 Jakub Jelinek > > > > * config/i386/i386.c (ix86_option_override_internal): Use > > cond ? G_("...") : G_("...") instead of just cond ? "..." : "...". > > * config/nvptx/nvptx.c (nvptx_goacc_validate_dims):

Re: [PATCH] Some more translation related tweaks

2017-03-01 Thread Tom de Vries
On 27/02/17 18:33, Jakub Jelinek wrote: On Mon, Feb 27, 2017 at 12:47:09PM +, Joseph Myers wrote: On Mon, 27 Feb 2017, Jakub Jelinek wrote: On Mon, Feb 27, 2017 at 11:04:36AM +0100, Volker Reichelt wrote: This is not -Wformat-security friendly, perhaps better pedwarn (EXPR_LOC_O

Re: [PATCH] Some more translation related tweaks

2017-02-27 Thread Joseph Myers
On Mon, 27 Feb 2017, Jakub Jelinek wrote: > > Yes, it's generally the case that G_() is used whenever there's a > > conditional expression for the msgid argument to a diagnostic function. > > So, is this ok for trunk? Shall I regenerate gcc.pot or will you? OK. I'll regenerate gcc.pot in a fe

Re: [PATCH] Some more translation related tweaks

2017-02-27 Thread Jakub Jelinek
On Mon, Feb 27, 2017 at 12:47:09PM +, Joseph Myers wrote: > On Mon, 27 Feb 2017, Jakub Jelinek wrote: > > > On Mon, Feb 27, 2017 at 11:04:36AM +0100, Volker Reichelt wrote: > > > > This is not -Wformat-security friendly, perhaps better > > > > pedwarn (EXPR_LOC_OR_LOC (outer_nelts, i

Re: [PATCH] Some more translation related tweaks

2017-02-27 Thread Volker Reichelt
On 27 Feb, Jakub Jelinek wrote: > On Mon, Feb 27, 2017 at 11:04:36AM +0100, Volker Reichelt wrote: >> So here's the second attempt: >> >> 2017-02-27 Volker Reichelt >> >> * init.c: Include intl.h. >> (build_new_1): Move message strings into pedwarn to make them >> -Wformat-secur

Re: [PATCH] Some more translation related tweaks

2017-02-27 Thread Jakub Jelinek
On Mon, Feb 27, 2017 at 11:04:36AM +0100, Volker Reichelt wrote: > So here's the second attempt: > > 2017-02-27 Volker Reichelt > > * init.c: Include intl.h. > (build_new_1): Move message strings into pedwarn to make them > -Wformat-security friendly. Mark string for translat

Re: [PATCH] Some more translation related tweaks

2017-02-27 Thread Joseph Myers
On Mon, 27 Feb 2017, Jakub Jelinek wrote: > On Mon, Feb 27, 2017 at 11:04:36AM +0100, Volker Reichelt wrote: > > > This is not -Wformat-security friendly, perhaps better > > > pedwarn (EXPR_LOC_OR_LOC (outer_nelts, input_location), OPT_Wvla, > > > typedef_variant_p (orig_type) > >

Re: [PATCH] Some more translation related tweaks

2017-02-27 Thread Jakub Jelinek
On Mon, Feb 27, 2017 at 11:04:36AM +0100, Volker Reichelt wrote: > > This is not -Wformat-security friendly, perhaps better > > pedwarn (EXPR_LOC_OR_LOC (outer_nelts, input_location), OPT_Wvla, > >typedef_variant_p (orig_type) > >? "non-constant array new lengt

Re: [PATCH] Some more translation related tweaks

2017-02-27 Thread Volker Reichelt
On 26 Feb, Jakub Jelinek wrote: > On Sun, Feb 26, 2017 at 01:18:57PM +0100, Volker Reichelt wrote: >> 2017-02-26 Volker Reichelt >> >> * init.c: Include intl.h > > Missing . Indeed, I noticed that one after I hit the send button. >> @@ -29,6 +29,7 @@ >> #include "varasm.h" >> #include

Re: [PATCH] Some more translation related tweaks

2017-02-26 Thread Jakub Jelinek
On Sun, Feb 26, 2017 at 01:18:57PM +0100, Volker Reichelt wrote: > 2017-02-26 Volker Reichelt > > * init.c: Include intl.h Missing . > @@ -29,6 +29,7 @@ > #include "varasm.h" > #include "gimplify.h" > #include "c-family/c-ubsan.h" > +#include "intl.h" > > static bool begin_init_st

[PATCH] Some more translation related tweaks

2017-02-26 Thread Volker Reichelt
After Jakub's and Marek's latest translation patches, I grepped for other unmarked messages. Here's what I found in the C++ front-end. Bootstrapped/regtested on x86_64-linux, ok for trunk? Regards, Volker 2017-02-26 Volker Reichelt * init.c: Include intl.h (build_new_1): Mar