Re: [PATCH] Revert "Pass GUILE down to subdirectories"

2024-03-22 Thread Tom Tromey
> "Andrew" == Andrew Burgess writes: Andrew> Thanks, that would be great, and would certainly fix the build problems Andrew> I see. I'm going to check it in to binutils-gdb in a minute. For those reading on gcc-patches, please consider this a ping of the patch. thanks, Tom

Re: [PATCH] Revert "Pass GUILE down to subdirectories"

2024-03-11 Thread Andrew Burgess
Tom Tromey writes: >> "Andrew" == Andrew Burgess writes: > > Andrew> Tom Tromey writes: >>> This reverts commit b7e5a29602143b53267efcd9c8d5ecc78cd5a62f. >>> >>> This patch caused problems for some users when building gdb, because >>> it would cause 'guild' to be invoked with the wrong ver

Re: [PATCH] Revert "Pass GUILE down to subdirectories"

2024-03-08 Thread Tom Tromey
> "Andrew" == Andrew Burgess writes: Andrew> After once again forgetting to add GUILE=guile2.2 to my GDB build I was Andrew> thinking about this issue again. Andrew> Given that GDB has a --with-guile=... configure option, and that our Andrew> configure scripts try to identify a matching vers

Re: [PATCH] Revert "Pass GUILE down to subdirectories"

2024-03-06 Thread Andrew Burgess
Tom Tromey writes: > This reverts commit b7e5a29602143b53267efcd9c8d5ecc78cd5a62f. > > This patch caused problems for some users when building gdb, because > it would cause 'guild' to be invoked with the wrong versin of guile. > On the whole it seems simpler to just back this out. Tom, After

Re: [PATCH] Revert "Pass GUILE down to subdirectories"

2024-02-10 Thread Tom Tromey
> "Andrew" == Andrew Burgess writes: Andrew> Tom Tromey writes: >> This reverts commit b7e5a29602143b53267efcd9c8d5ecc78cd5a62f. >> >> This patch caused problems for some users when building gdb, because >> it would cause 'guild' to be invoked with the wrong versin of guile. >> On the whole

Re: [PATCH] Revert "Pass GUILE down to subdirectories"

2024-02-08 Thread Christian Biesinger
On Thu, Feb 8, 2024 at 11:10 AM Andrew Burgess wrote: > > Christian Biesinger writes: > > > On Mon, Jan 22, 2024 at 7:21 PM Tom Tromey wrote: > > > >> This reverts commit b7e5a29602143b53267efcd9c8d5ecc78cd5a62f. > >> > >> This patch caused problems for some users when building gdb, because > >>

Re: [PATCH] Revert "Pass GUILE down to subdirectories"

2024-02-08 Thread Andrew Burgess
Christian Biesinger writes: > On Mon, Jan 22, 2024 at 7:21 PM Tom Tromey wrote: > >> This reverts commit b7e5a29602143b53267efcd9c8d5ecc78cd5a62f. >> >> This patch caused problems for some users when building gdb, because >> it would cause 'guild' to be invoked with the wrong versin of guile. >>

Re: [PATCH] Revert "Pass GUILE down to subdirectories"

2024-02-07 Thread Christian Biesinger
On Mon, Jan 22, 2024 at 7:21 PM Tom Tromey wrote: > This reverts commit b7e5a29602143b53267efcd9c8d5ecc78cd5a62f. > > This patch caused problems for some users when building gdb, because > it would cause 'guild' to be invoked with the wrong versin of guile. > Is "guild" here a typo? (I don't see

Re: [PATCH] Revert "Pass GUILE down to subdirectories"

2024-02-07 Thread Andrew Burgess
Tom Tromey writes: > This reverts commit b7e5a29602143b53267efcd9c8d5ecc78cd5a62f. > > This patch caused problems for some users when building gdb, because > it would cause 'guild' to be invoked with the wrong versin of guile. > On the whole it seems simpler to just back this out. > > * Mak

[PATCH] Revert "Pass GUILE down to subdirectories"

2024-01-22 Thread Tom Tromey
This reverts commit b7e5a29602143b53267efcd9c8d5ecc78cd5a62f. This patch caused problems for some users when building gdb, because it would cause 'guild' to be invoked with the wrong versin of guile. On the whole it seems simpler to just back this out. * Makefile.in: Rebuild. * Ma