Re: [PATCH] Remove lambdas from _Rb_tree

2020-11-20 Thread Jonathan Wakely via Gcc-patches
On 20/11/20 08:17 +0100, François Dumont via Libstdc++ wrote: Here is what I am testing. I use your enum proposal as an alias for the bool type. I cannot use it as template parameter on _M_copy unless I put it at std namespace level to use it in definition of the outline _M_copy overload. Y

Re: [PATCH] Remove lambdas from _Rb_tree

2020-11-19 Thread François Dumont via Gcc-patches
Here is what I am testing. I use your enum proposal as an alias for the bool type. I cannot use it as template parameter on _M_copy unless I put it at std namespace level to use it in definition of the outline _M_copy overload. I also added some tests checking correct usage of __move_if_noex

Re: [PATCH] Remove lambdas from _Rb_tree

2020-11-19 Thread François Dumont via Gcc-patches
On 19/11/20 12:31 pm, Jonathan Wakely wrote: On 19/11/20 07:46 +0100, François Dumont via Libstdc++ wrote: On 18/11/20 12:50 am, Jonathan Wakely wrote: On 17/11/20 21:51 +0100, François Dumont via Libstdc++ wrote: This is a change that has been done to _Hashtable and that I forgot to propo

Re: [PATCH] Remove lambdas from _Rb_tree

2020-11-19 Thread Jonathan Wakely via Gcc-patches
On 19/11/20 07:46 +0100, François Dumont via Libstdc++ wrote: On 18/11/20 12:50 am, Jonathan Wakely wrote: On 17/11/20 21:51 +0100, François Dumont via Libstdc++ wrote: This is a change that has been done to _Hashtable and that I forgot to propose for _Rb_tree. The _GLIBCXX_XREF macro can

Re: [PATCH] Remove lambdas from _Rb_tree

2020-11-18 Thread François Dumont via Gcc-patches
On 18/11/20 12:50 am, Jonathan Wakely wrote: On 17/11/20 21:51 +0100, François Dumont via Libstdc++ wrote: This is a change that has been done to _Hashtable and that I forgot to propose for _Rb_tree. The _GLIBCXX_XREF macro can be easily removed of course.     libstdc++: _Rb_tree code cle

Re: [PATCH] Remove lambdas from _Rb_tree

2020-11-17 Thread Jonathan Wakely via Gcc-patches
On 17/11/20 21:51 +0100, François Dumont via Libstdc++ wrote: This is a change that has been done to _Hashtable and that I forgot to propose for _Rb_tree. The _GLIBCXX_XREF macro can be easily removed of course.     libstdc++: _Rb_tree code cleanup, remove lambdas.     Use an additiona

[PATCH] Remove lambdas from _Rb_tree

2020-11-17 Thread François Dumont via Gcc-patches
This is a change that has been done to _Hashtable and that I forgot to propose for _Rb_tree. The _GLIBCXX_XREF macro can be easily removed of course.     libstdc++: _Rb_tree code cleanup, remove lambdas.     Use an additional template parameter on the clone method to propagate if the values m