Re: [PATCH] Remove a barrier when EDGE_CROSSING is remoed (PR lto/88858).

2019-02-12 Thread Martin Liška
On 2/11/19 10:00 AM, Jan Hubicka wrote: > Aha, yes, fundament of the patch is obvious - the barrier has to go :) > There is same hunk of code in cfgrtl.c:1061, so please just merge it > Note that I am not rtl reviewer. But as author of the code I would say > that the updated patch can go in as obvi

Re: [PATCH] Remove a barrier when EDGE_CROSSING is remoed (PR lto/88858).

2019-02-11 Thread Jan Hubicka
> @Honza: PING^2 > > On 2/4/19 9:09 AM, Martin Liška wrote: > > @Honza: PING^1 > > > > Martin > > > > On 1/24/19 9:10 AM, Martin Liška wrote: > >> On 1/23/19 7:28 PM, Segher Boessenkool wrote: > >>> Hi Martin, > >>> > >>> On Wed, Jan 23, 2019 at 10:29:40AM +0100, Martin Liška wrote: > diff

Re: [PATCH] Remove a barrier when EDGE_CROSSING is remoed (PR lto/88858).

2019-02-11 Thread Martin Liška
@Honza: PING^2 On 2/4/19 9:09 AM, Martin Liška wrote: > @Honza: PING^1 > > Martin > > On 1/24/19 9:10 AM, Martin Liška wrote: >> On 1/23/19 7:28 PM, Segher Boessenkool wrote: >>> Hi Martin, >>> >>> On Wed, Jan 23, 2019 at 10:29:40AM +0100, Martin Liška wrote: diff --git a/gcc/cfgrtl.c b/gcc

Re: [PATCH] Remove a barrier when EDGE_CROSSING is remoed (PR lto/88858).

2019-02-04 Thread Steven Bosscher
On Mon, Feb 4, 2019 at 9:10 AM Martin Liška wrote: > > @Honza: PING^1 > >>> + else > >>> + { > >>> + if (PREV_INSN (insn)) > >>> + SET_NEXT_INSN (PREV_INSN (insn)) = NEXT_INSN (insn); > >>> + if (NEXT_INSN (insn)) > >>> + SET_PREV_INSN (NEXT_INSN (insn)

Re: [PATCH] Remove a barrier when EDGE_CROSSING is remoed (PR lto/88858).

2019-02-04 Thread Martin Liška
@Honza: PING^1 Martin On 1/24/19 9:10 AM, Martin Liška wrote: > On 1/23/19 7:28 PM, Segher Boessenkool wrote: >> Hi Martin, >> >> On Wed, Jan 23, 2019 at 10:29:40AM +0100, Martin Liška wrote: >>> diff --git a/gcc/cfgrtl.c b/gcc/cfgrtl.c >>> index 172bdf585d0..5dd316efb63 100644 >>> --- a/gcc/cfgr

Re: [PATCH] Remove a barrier when EDGE_CROSSING is remoed (PR lto/88858).

2019-01-24 Thread Martin Liška
On 1/23/19 7:28 PM, Segher Boessenkool wrote: > Hi Martin, > > On Wed, Jan 23, 2019 at 10:29:40AM +0100, Martin Liška wrote: >> diff --git a/gcc/cfgrtl.c b/gcc/cfgrtl.c >> index 172bdf585d0..5dd316efb63 100644 >> --- a/gcc/cfgrtl.c >> +++ b/gcc/cfgrtl.c >> @@ -4396,6 +4396,25 @@ cfg_layout_redirec

Re: [PATCH] Remove a barrier when EDGE_CROSSING is remoed (PR lto/88858).

2019-01-23 Thread Segher Boessenkool
Hi Martin, On Wed, Jan 23, 2019 at 10:29:40AM +0100, Martin Liška wrote: > diff --git a/gcc/cfgrtl.c b/gcc/cfgrtl.c > index 172bdf585d0..5dd316efb63 100644 > --- a/gcc/cfgrtl.c > +++ b/gcc/cfgrtl.c > @@ -4396,6 +4396,25 @@ cfg_layout_redirect_edge_and_branch (edge e, > basic_block dest) >

[PATCH] Remove a barrier when EDGE_CROSSING is remoed (PR lto/88858).

2019-01-23 Thread Martin Liška
Hi. The PR is about a verification error where we have a FALLTHRU edge that contains barrier instruction. The instruction is created during bbpart pass in add_labels_and_missing_jumps (emit_barrier_after_bb). At that time, the basic blocks live in a different partition (hot,cold). Later then the e