On Thu, Oct 25, 2012 at 01:28:32PM -0700, Teresa Johnson wrote:
> > 2012-10-18 Teresa Johnson
> >
> > * ree.c (add_removable_extension): Remove unnecessary
> > mode check with other extension.
> >
> > 2012-10-18 Teresa Johnson
> >
> > * gcc.c-torture/execute/20111227-2
ping.
Teresa
On Thu, Oct 18, 2012 at 8:21 AM, Teresa Johnson wrote:
>
> The attached patch implements avoids conservative behavior in REE by allowing
> removal of redundant extends when the def feeds another extend with a
> different
> mode. This works because in merge_def_and_ext only calls com
The attached patch implements avoids conservative behavior in REE by allowing
removal of redundant extends when the def feeds another extend with a different
mode. This works because in merge_def_and_ext only calls combine_set_extension
if the candidate for removal has a wider mode than the def ext
The change to remove mode check looks good to me.
Not directly related to this bug but somehow related: the REE has
obvious conservativeness regarding partial redundancy (i.e., not all
reaching def has the bits properly extended). However, there are bugs
preventing elimination even with full redu
On Fri, Oct 12, 2012 at 1:23 AM, Jakub Jelinek wrote:
> On Thu, Oct 11, 2012 at 02:44:12PM -0700, Teresa Johnson wrote:
>> Revised patch to address conservative behavior in redundant extend
>> elimination that was resulting in redundant extends not being
>> removed. Now uses a new target hook mach
On Thu, Oct 11, 2012 at 02:44:12PM -0700, Teresa Johnson wrote:
> Revised patch to address conservative behavior in redundant extend
> elimination that was resulting in redundant extends not being
> removed. Now uses a new target hook machine_mode_from_attr_mode
> which is currently enabled only fo
On Thu, Oct 11, 2012 at 11:44 PM, Teresa Johnson wrote:
> + mode = targetm.machine_mode_from_attr_mode(insn);
Nit: space between "..._mode" and "(".
A test case would also be Nice To Have.
Looks OK to me otherwise, but I can't approve it.
Ciao!
Steven
Revised patch to address conservative behavior in redundant extend
elimination that was resulting in redundant extends not being
removed. Now uses a new target hook machine_mode_from_attr_mode
which is currently enabled only for i386.
Bootstrapped and tested on x86_64-unknown-linux-gnu. Is this ok
On Wed, Oct 10, 2012 at 11:25 PM, Teresa Johnson wrote:
> What I did to address this is to call get_attr_mode from the machine model
> to get the actual mode of the insn. In this case, it returns MODE_SI.
> There doesn't seem to be any code that maps from the attr_mode (MODE_SI)
> to the machine_m
This patch addresses conservative behavior in redundant extend
elimination that was resulting in redundant extends not being
removed.
One of the checks is to ensure that the reaching definition doesn't
feed another extension with a different machine mode.
In this case, the extend we are trying to
10 matches
Mail list logo
