Re: [PATCH] Redesign jump threading profile updates

2014-10-28 Thread Renlin Li
On 01/10/14 21:04, Teresa Johnson wrote: The block frequencies are very small in this case leading to rounding errors when computing the edge frequency. The rounding error was then propagated into the recomputed probabilities, leading to insanities in the outgoing edge probabilities on the jump t

Re: [PATCH] Redesign jump threading profile updates

2014-10-02 Thread Jeff Law
On 10/01/14 14:04, Teresa Johnson wrote: The block frequencies are very small in this case leading to rounding errors when computing the edge frequency. The rounding error was then propagated into the recomputed probabilities, leading to insanities in the outgoing edge probabilities on the jump t

Re: [PATCH] Redesign jump threading profile updates

2014-10-02 Thread Teresa Johnson
On Thu, Oct 2, 2014 at 8:45 AM, Steve Ellcey wrote: > On Wed, 2014-10-01 at 22:02 -0700, Teresa Johnson wrote: > >> Will take a look. In case I can't reproduce it with the aarch64 >> cross-compiler or x86_64, can you give me the preprocessed source? And >> also the instructions for how to configur

Re: [PATCH] Redesign jump threading profile updates

2014-10-02 Thread Steve Ellcey
On Wed, 2014-10-01 at 22:02 -0700, Teresa Johnson wrote: > Will take a look. In case I can't reproduce it with the aarch64 > cross-compiler or x86_64, can you give me the preprocessed source? And > also the instructions for how to configure for MIPS. > > Teresa Never mind, I messed up the patch

Re: [PATCH] Redesign jump threading profile updates

2014-10-02 Thread Teresa Johnson
On Wed, Oct 1, 2014 at 10:02 PM, Teresa Johnson wrote: > On Wed, Oct 1, 2014 at 3:46 PM, Steve Ellcey wrote: >> On Wed, 2014-10-01 at 13:04 -0700, Teresa Johnson wrote: >> >>> 2014-10-01 Teresa Johnson >>> >>> * tree-ssa-threadupdate.c (freqs_to_counts_path): Scale frequencies >>>

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
On Wed, Oct 1, 2014 at 4:09 PM, Jan Hubicka wrote: >> The block frequencies are very small in this case leading to rounding >> errors when computing the edge frequency. The rounding error was then >> propagated into the recomputed probabilities, leading to insanities in >> the outgoing edge probab

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
On Wed, Oct 1, 2014 at 3:46 PM, Steve Ellcey wrote: > On Wed, 2014-10-01 at 13:04 -0700, Teresa Johnson wrote: > >> 2014-10-01 Teresa Johnson >> >> * tree-ssa-threadupdate.c (freqs_to_counts_path): Scale frequencies >> up when synthesizing counts to avoid rounding errors. > > I

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Jan Hubicka
> The block frequencies are very small in this case leading to rounding > errors when computing the edge frequency. The rounding error was then > propagated into the recomputed probabilities, leading to insanities in > the outgoing edge probabilities on the jump threading path. Eventually > during

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Steve Ellcey
On Wed, 2014-10-01 at 13:04 -0700, Teresa Johnson wrote: > 2014-10-01 Teresa Johnson > > * tree-ssa-threadupdate.c (freqs_to_counts_path): Scale frequencies > up when synthesizing counts to avoid rounding errors. I tried this patch on my MIPS toolchain build but GCC is still f

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
The block frequencies are very small in this case leading to rounding errors when computing the edge frequency. The rounding error was then propagated into the recomputed probabilities, leading to insanities in the outgoing edge probabilities on the jump threading path. Eventually during rtl expans

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
On Wed, Oct 1, 2014 at 9:20 AM, H.J. Lu wrote: > On Wed, Oct 1, 2014 at 8:29 AM, Teresa Johnson wrote: >> I got the preprocessed source. With the aarch64 cross-compiler I built >> I am able to reproduce the ICE. Looking at it now. > > It may also cause: > > https://gcc.gnu.org/bugzilla/show_bug.c

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread H.J. Lu
On Wed, Oct 1, 2014 at 8:29 AM, Teresa Johnson wrote: > I got the preprocessed source. With the aarch64 cross-compiler I built > I am able to reproduce the ICE. Looking at it now. It may also cause: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63432 -- H.J.

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Sebastian Pop
Christophe Lyon wrote: > I did it in a followup mail, but the list server rejected it because > it was too large. > I suppose Teresa did receive it though. > > Not sure whether I can attach it in .xz format? Is this allowed? You can open a bug report and attach the preprocessed file there. Thank

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
I got the preprocessed source. With the aarch64 cross-compiler I built I am able to reproduce the ICE. Looking at it now. Thanks, Teresa On Wed, Oct 1, 2014 at 8:25 AM, Christophe Lyon wrote: > On 1 October 2014 17:22, Sebastian Pop wrote: >> Christophe Lyon wrote: >>> Since this commit, I can

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Christophe Lyon
On 1 October 2014 17:22, Sebastian Pop wrote: > Christophe Lyon wrote: >> Since this commit, I can see all my builds for arm*linux* and >> aarch64*linux* fail while building glibc: >> >> /tmp/3496222_18.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/bin/aarch64-none-linux-gnu-gcc >> iso-2022-cn.c

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Sebastian Pop
Christophe Lyon wrote: > Since this commit, I can see all my builds for arm*linux* and > aarch64*linux* fail while building glibc: > > /tmp/3496222_18.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/bin/aarch64-none-linux-gnu-gcc > iso-2022-cn.c -c -std=gnu99 -fgnu89-inline -O2 -Wall -Win > line -

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
On Wed, Oct 1, 2014 at 6:20 AM, Teresa Johnson wrote: > Sorry, yes, will try to reproduce. > Teresa > > On Wed, Oct 1, 2014 at 12:03 AM, Christophe Lyon > wrote: >> On 30 September 2014 20:20, Teresa Johnson wrote: >>> On Mon, Sep 29, 2014 at 9:33 PM, Jeff Law wrote: On 09/29/14 08:19, Ter

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
Sorry, yes, will try to reproduce. Teresa On Wed, Oct 1, 2014 at 12:03 AM, Christophe Lyon wrote: > On 30 September 2014 20:20, Teresa Johnson wrote: >> On Mon, Sep 29, 2014 at 9:33 PM, Jeff Law wrote: >>> On 09/29/14 08:19, Teresa Johnson wrote: > > > Just an update - I found some

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Christophe Lyon
On 30 September 2014 20:20, Teresa Johnson wrote: > On Mon, Sep 29, 2014 at 9:33 PM, Jeff Law wrote: >> On 09/29/14 08:19, Teresa Johnson wrote: Just an update - I found some good test cases by compiling the c-torture tests with profile feedback with and without my patch. But

Re: [PATCH] Redesign jump threading profile updates

2014-09-30 Thread Teresa Johnson
On Mon, Sep 29, 2014 at 9:33 PM, Jeff Law wrote: > On 09/29/14 08:19, Teresa Johnson wrote: >>> >>> >>> Just an update - I found some good test cases by compiling the >>> c-torture tests with profile feedback with and without my patch. But >>> in the cases I pulled out I saw that there were still

Re: [PATCH] Redesign jump threading profile updates

2014-09-29 Thread Jeff Law
On 09/29/14 08:19, Teresa Johnson wrote: Just an update - I found some good test cases by compiling the c-torture tests with profile feedback with and without my patch. But in the cases I pulled out I saw that there were still a couple profile or probability insanities introduced by jump threadi

Re: [PATCH] Redesign jump threading profile updates

2014-09-29 Thread Teresa Johnson
On Fri, Aug 1, 2014 at 10:10 PM, Teresa Johnson wrote: > On Wed, Jul 23, 2014 at 2:08 PM, Teresa Johnson wrote: >> On Tue, Jul 22, 2014 at 7:29 PM, Jeff Law wrote: >>> On 03/26/14 17:44, Teresa Johnson wrote: Recently I discovered that the profile updates being performed by jump t

Re: [PATCH] Redesign jump threading profile updates

2014-08-01 Thread Andrew Pinski
On Fri, Aug 1, 2014 at 10:10 PM, Teresa Johnson wrote: > On Wed, Jul 23, 2014 at 2:08 PM, Teresa Johnson wrote: >> On Tue, Jul 22, 2014 at 7:29 PM, Jeff Law wrote: >>> On 03/26/14 17:44, Teresa Johnson wrote: Recently I discovered that the profile updates being performed by jump t

Re: [PATCH] Redesign jump threading profile updates

2014-08-01 Thread Teresa Johnson
On Wed, Jul 23, 2014 at 2:08 PM, Teresa Johnson wrote: > On Tue, Jul 22, 2014 at 7:29 PM, Jeff Law wrote: >> On 03/26/14 17:44, Teresa Johnson wrote: >>> >>> Recently I discovered that the profile updates being performed by jump >>> threading were incorrect in many cases, particularly in the case

Re: [PATCH] Redesign jump threading profile updates

2014-07-23 Thread Teresa Johnson
On Tue, Jul 22, 2014 at 7:29 PM, Jeff Law wrote: > On 03/26/14 17:44, Teresa Johnson wrote: >> >> Recently I discovered that the profile updates being performed by jump >> threading were incorrect in many cases, particularly in the case where >> the threading path contains a joiner. Some of the du

Re: [PATCH] Redesign jump threading profile updates

2014-07-23 Thread Jeff Law
On 03/26/14 17:44, Teresa Johnson wrote: Recently I discovered that the profile updates being performed by jump threading were incorrect in many cases, particularly in the case where the threading path contains a joiner. Some of the duplicated blocks/edges were not getting any counts, leading to

Re: [PATCH] Redesign jump threading profile updates

2014-07-07 Thread Jeff Law
On 07/07/14 15:22, Teresa Johnson wrote: Ping. Jeff, any update on when you can look at this? Hoping to do so on that long plane ride to the UK for Cauldron :-) SLC->LAX->Heathrow Lots of uninterrupted time to look at those changes. Jeff

Re: [PATCH] Redesign jump threading profile updates

2014-07-07 Thread Teresa Johnson
Ping. Jeff, any update on when you can look at this? Thanks, Teresa On Tue, May 27, 2014 at 7:10 AM, Teresa Johnson wrote: > On Thu, Apr 17, 2014 at 6:23 AM, Teresa Johnson wrote: >> On Wed, Apr 16, 2014 at 10:39 PM, Jeff Law wrote: >>> On 03/26/14 17:44, Teresa Johnson wrote: Recentl

Re: [PATCH] Redesign jump threading profile updates

2014-05-27 Thread Teresa Johnson
On Thu, Apr 17, 2014 at 6:23 AM, Teresa Johnson wrote: > On Wed, Apr 16, 2014 at 10:39 PM, Jeff Law wrote: >> On 03/26/14 17:44, Teresa Johnson wrote: >>> >>> Recently I discovered that the profile updates being performed by jump >>> threading were incorrect in many cases, particularly in the cas

Re: [PATCH] Redesign jump threading profile updates

2014-04-17 Thread Teresa Johnson
On Wed, Apr 16, 2014 at 10:39 PM, Jeff Law wrote: > On 03/26/14 17:44, Teresa Johnson wrote: >> >> Recently I discovered that the profile updates being performed by jump >> threading were incorrect in many cases, particularly in the case where >> the threading path contains a joiner. Some of the d

Re: [PATCH] Redesign jump threading profile updates

2014-04-16 Thread Jeff Law
On 03/26/14 17:44, Teresa Johnson wrote: Recently I discovered that the profile updates being performed by jump threading were incorrect in many cases, particularly in the case where the threading path contains a joiner. Some of the duplicated blocks/edges were not getting any counts, leading to