Re: Re: [PATCH] RISC-V: Refactor Phase 3 (Demand fusion) of VSETVL PASS

2023-08-23 Thread juzhe.zh...@rivai.ai
zhe.zh...@rivai.ai From: Kito Cheng Date: 2023-08-22 23:35 To: Kito Cheng CC: Robin Dapp; Juzhe-Zhong; GCC Patches; Jeff Law Subject: Re: [PATCH] RISC-V: Refactor Phase 3 (Demand fusion) of VSETVL PASS It's really great improvement, it's drop some state like HARD_EMPTY and DIRTY_WI

Re: Re: [PATCH] RISC-V: Refactor Phase 3 (Demand fusion) of VSETVL PASS

2023-08-22 Thread juzhe.zh...@rivai.ai
ctor. I committed it with a separate patch. Thanks. juzhe.zh...@rivai.ai From: Kito Cheng Date: 2023-08-22 23:35 To: Kito Cheng CC: Robin Dapp; Juzhe-Zhong; GCC Patches; Jeff Law Subject: Re: [PATCH] RISC-V: Refactor Phase 3 (Demand fusion) of VSETVL PASS It's really great improvement

Re: Re: [PATCH] RISC-V: Refactor Phase 3 (Demand fusion) of VSETVL PASS

2023-08-22 Thread 钟居哲
stcases, instead of "vl= 101", I make them "vl = a + 101", then the assembly check remain and pass. Thanks. juzhe.zh...@rivai.ai From: Kito Cheng Date: 2023-08-22 23:35 To: Kito Cheng CC: Robin Dapp; Juzhe-Zhong; GCC Patches; Jeff Law Subject: Re: [PATCH] RISC-V: Refac

Re: [PATCH] RISC-V: Refactor Phase 3 (Demand fusion) of VSETVL PASS

2023-08-22 Thread Kito Cheng via Gcc-patches
It's really great improvement, it's drop some state like HARD_EMPTY and DIRTY_WITH_KILLED_AVL which make this algorithm more easy to understand! also this also fundamentally improved the phase 3, although one concern is the time complexity might be come more higher order, (and it's already high eno

Re: [PATCH] RISC-V: Refactor Phase 3 (Demand fusion) of VSETVL PASS

2023-08-21 Thread Kito Cheng via Gcc-patches
I think I could do some details review tomorrow on the plane, I am free from the meeting hell tomorrow :p Robin Dapp via Gcc-patches 於 2023年8月21日 週一 23:24 寫道: > Hi Juzhe, > > thanks, this is a reasonable approach and improves readability noticeably. > LGTM but I'd like to wait for other opinio

Re: [PATCH] RISC-V: Refactor Phase 3 (Demand fusion) of VSETVL PASS

2023-08-21 Thread Robin Dapp via Gcc-patches
Hi Juzhe, thanks, this is a reasonable approach and improves readability noticeably. LGTM but I'd like to wait for other opinions (e.g. by Kito) as I haven't looked closely into the vsetvl pass before and cannot entirely review it quickly. As we already have good test coverage there is not much t

[PATCH] RISC-V: Refactor Phase 3 (Demand fusion) of VSETVL PASS

2023-08-20 Thread Juzhe-Zhong
This patch refactors the Phase 3 (Demand fusion) and rename it into Earliest fusion. I do the refactor for the following reasons: 1. Current implementation of phase 3 is doing too many things which makes the code quality quite messy and not easy to maintain. 2. The demand fusion I do