Re: Re: [PATCH] RISC-V: Implement autovec copysign.

2023-06-20 Thread juzhe.zh...@rivai.ai
LGTM as long as you remove all stuff related to UNSPEC_VNCOPYSIGN Thanks. juzhe.zh...@rivai.ai From: Robin Dapp Date: 2023-06-21 14:36 To: 钟居哲; gcc-patches; palmer; kito.cheng; Jeff Law CC: rdapp.gcc Subject: Re: [PATCH] RISC-V: Implement autovec copysign. > You should remove all &quo

Re: [PATCH] RISC-V: Implement autovec copysign.

2023-06-20 Thread Robin Dapp via Gcc-patches
> You should remove all "unspec" related of "n" ncopysign including  > riscv-vector-builtins-bases.cc > vector.md/ vector-iterators.md  Ah, there was indeed one stray UNSPEC_VNCOPYSIGN in the iterators, thanks. Any other comments before I sent V2? Regards Robin

Re: [PATCH] RISC-V: Implement autovec copysign.

2023-06-20 Thread 钟居哲
.gcc Subject: [PATCH] RISC-V: Implement autovec copysign. Hi, this adds vector copysign, ncopysign and xorsign as well as the accompanying tests. In order to easily match the ncopysign patterns I changed the builtin implementation slightly. Juzhe might want to comment on that. For now I kept t

[PATCH] RISC-V: Implement autovec copysign.

2023-06-20 Thread Robin Dapp via Gcc-patches
Hi, this adds vector copysign, ncopysign and xorsign as well as the accompanying tests. In order to easily match the ncopysign patterns I changed the builtin implementation slightly. Juzhe might want to comment on that. For now I kept the attribute's name even though it doesn't emit an "n" any