Re: [PATCH] Put -lasan always very early on the ld command line (PR sanitizer/55374)

2013-02-05 Thread Jakub Jelinek
On Tue, Feb 05, 2013 at 09:37:29AM +0100, Eric Botcazou wrote: > Tested on x86_64-suse-linux, OK for the mainline? > > > 2013-02-05 Eric Botcazou > > PR sanitizer/55374 > * config/gnu-user.h (LIBASAN_EARLY_SPEC): Add missing guard. Yes, thanks. > Index: config/gnu-user.h > =

Re: [PATCH] Put -lasan always very early on the ld command line (PR sanitizer/55374)

2013-02-05 Thread Eric Botcazou
> 2013-01-22 Jakub Jelinek > > PR sanitizer/55374 > * gcc.c (LIBASAN_SPEC): Define just to ADD_STATIC_LIBASAN_LIBS if > LIBASAN_EARLY_SPEC is defined. > (LIBASAN_EARLY_SPEC): Define to empty string if not already defined. > (LINK_COMMAND_SPEC): Add LIBASAN_EARLY_SP

Re: [PATCH] Put -lasan always very early on the ld command line (PR sanitizer/55374)

2013-01-30 Thread Jakub Jelinek
On Wed, Jan 30, 2013 at 04:04:55PM +0100, Dodji Seketeli wrote: > As an aside, I am curious why about ... > > > --- gcc/testsuite/g++.dg/asan/deep-stack-uaf-1.C.jj 2012-12-14 > > 16:24:38.0 +0100 > > +++ gcc/testsuite/g++.dg/asan/deep-stack-uaf-1.C2013-01-22 > > 16:43:03.337091101 +0

Re: [PATCH] Put -lasan always very early on the ld command line (PR sanitizer/55374)

2013-01-30 Thread Dodji Seketeli
Jakub Jelinek writes: > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > 2013-01-22 Jakub Jelinek > > PR sanitizer/55374 > * gcc.c (LIBASAN_SPEC): Define just to ADD_STATIC_LIBASAN_LIBS if > LIBASAN_EARLY_SPEC is defined. > (LIBASAN_EARLY_SPEC):

Re: [PATCH] Put -lasan always very early on the ld command line (PR sanitizer/55374)

2013-01-30 Thread Jason Merrill
Looks good to me. OK if nobody else responds today. Jason

[PATCH] Put -lasan always very early on the ld command line (PR sanitizer/55374)

2013-01-22 Thread Jakub Jelinek
Hi! libasan relies on being linked before -lpthread, -lstdc++ and -lc, but so far nothing was ensuring that. Not only e.g. -lstdc++ could come before -lasan when -lstdc++ was added by g++ language specific driver handling, but also if the user specifies -lstdc++, -lpthread or -lc somewhere on the