Re: [PATCH] Properly honor param_max_fsm_thread_path_insns in backwards threader

2022-08-05 Thread Jeff Law via Gcc-patches
On 8/2/2022 7:00 AM, Richard Biener via Gcc-patches wrote: I am trying to make sense of back_threader_profitability::profitable_path_p and the first thing I notice is that we do /* Threading is profitable if the path duplicated is hot but also in a case we separate cold path from hot

Re: [PATCH] Properly honor param_max_fsm_thread_path_insns in backwards threader

2022-08-03 Thread Richard Biener via Gcc-patches
On Tue, 2 Aug 2022, Jan Hubicka wrote: > > On Tue, 2 Aug 2022, Aldy Hernandez wrote: > > > > > On Tue, Aug 2, 2022 at 1:45 PM Richard Biener wrote: > > > > > > > > On Tue, 2 Aug 2022, Aldy Hernandez wrote: > > > > > > > > > Unfortunately, this was before my time, so I don't know. > > > > > > > >

Re: [PATCH] Properly honor param_max_fsm_thread_path_insns in backwards threader

2022-08-02 Thread Jan Hubicka via Gcc-patches
> On Tue, 2 Aug 2022, Aldy Hernandez wrote: > > > On Tue, Aug 2, 2022 at 1:45 PM Richard Biener wrote: > > > > > > On Tue, 2 Aug 2022, Aldy Hernandez wrote: > > > > > > > Unfortunately, this was before my time, so I don't know. > > > > > > > > That being said, thanks for tackling these issues tha

Re: [PATCH] Properly honor param_max_fsm_thread_path_insns in backwards threader

2022-08-02 Thread Aldy Hernandez via Gcc-patches
Feel free to blame me for everything except the profitability code and the generic block copier. That stuff was all there before and I mostly avoided it. :-) Thanks for the work in this space. Aldy On Tue, Aug 2, 2022, 15:29 Richard Biener wrote: > On Tue, 2 Aug 2022, Aldy Hernandez wrote: > >

Re: [PATCH] Properly honor param_max_fsm_thread_path_insns in backwards threader

2022-08-02 Thread Richard Biener via Gcc-patches
On Tue, 2 Aug 2022, Aldy Hernandez wrote: > On Tue, Aug 2, 2022 at 1:59 PM Richard Biener wrote: > > > > On Tue, 2 Aug 2022, Aldy Hernandez wrote: > > > > > On Tue, Aug 2, 2022 at 1:45 PM Richard Biener wrote: > > > > > > > > On Tue, 2 Aug 2022, Aldy Hernandez wrote: > > > > > > > > > Unfortunat

[PATCH] Properly honor param_max_fsm_thread_path_insns in backwards threader

2022-08-02 Thread Richard Biener via Gcc-patches
I am trying to make sense of back_threader_profitability::profitable_path_p and the first thing I notice is that we do /* Threading is profitable if the path duplicated is hot but also in a case we separate cold path from hot path and permit optimization of the hot path later. Be on t

Re: [PATCH] Properly honor param_max_fsm_thread_path_insns in backwards threader

2022-08-02 Thread Aldy Hernandez via Gcc-patches
On Tue, Aug 2, 2022 at 1:59 PM Richard Biener wrote: > > On Tue, 2 Aug 2022, Aldy Hernandez wrote: > > > On Tue, Aug 2, 2022 at 1:45 PM Richard Biener wrote: > > > > > > On Tue, 2 Aug 2022, Aldy Hernandez wrote: > > > > > > > Unfortunately, this was before my time, so I don't know. > > > > > > >

Re: [PATCH] Properly honor param_max_fsm_thread_path_insns in backwards threader

2022-08-02 Thread Richard Biener via Gcc-patches
On Tue, 2 Aug 2022, Aldy Hernandez wrote: > On Tue, Aug 2, 2022 at 1:45 PM Richard Biener wrote: > > > > On Tue, 2 Aug 2022, Aldy Hernandez wrote: > > > > > Unfortunately, this was before my time, so I don't know. > > > > > > That being said, thanks for tackling these issues that my work > > > tr

Re: [PATCH] Properly honor param_max_fsm_thread_path_insns in backwards threader

2022-08-02 Thread Aldy Hernandez via Gcc-patches
On Tue, Aug 2, 2022 at 1:45 PM Richard Biener wrote: > > On Tue, 2 Aug 2022, Aldy Hernandez wrote: > > > Unfortunately, this was before my time, so I don't know. > > > > That being said, thanks for tackling these issues that my work > > triggered last release. Much appreciated. > > Ah. But it wa

Re: [PATCH] Properly honor param_max_fsm_thread_path_insns in backwards threader

2022-08-02 Thread Richard Biener via Gcc-patches
On Tue, 2 Aug 2022, Aldy Hernandez wrote: > Unfortunately, this was before my time, so I don't know. > > That being said, thanks for tackling these issues that my work > triggered last release. Much appreciated. Ah. But it was your r12-324-g69e5544210e3c0 that did - else if (n_insns > 1) +

Re: [PATCH] Properly honor param_max_fsm_thread_path_insns in backwards threader

2022-08-02 Thread Aldy Hernandez via Gcc-patches
Unfortunately, this was before my time, so I don't know. That being said, thanks for tackling these issues that my work triggered last release. Much appreciated. Aldy On Tue, Aug 2, 2022 at 10:41 AM Richard Biener wrote: > > I am trying to make sense of back_threader_profitability::profitable_

[PATCH] Properly honor param_max_fsm_thread_path_insns in backwards threader

2022-08-02 Thread Richard Biener via Gcc-patches
I am trying to make sense of back_threader_profitability::profitable_path_p and the first thing I notice is that we do /* Threading is profitable if the path duplicated is hot but also in a case we separate cold path from hot path and permit optimization of the hot path later. Be on t