Re: [PATCH] Properly do the LTO bytecode version check

2014-03-04 Thread Richard Biener
On Tue, 4 Mar 2014, Marc Glisse wrote: > On Tue, 4 Mar 2014, Richard Biener wrote: > > > We're doing the LTO bytecode version check only for two section > > types at the moment - specifically _not_ for the first section > > we read. Which causes us to crash instead of reporting a > > version mis

Re: [PATCH] Properly do the LTO bytecode version check

2014-03-04 Thread Marc Glisse
On Tue, 4 Mar 2014, Richard Biener wrote: We're doing the LTO bytecode version check only for two section types at the moment - specifically _not_ for the first section we read. Which causes us to crash instead of reporting a version mismatch ... Not for 4.9, but when the object is fat, could

Re: [PATCH] Properly do the LTO bytecode version check

2014-03-04 Thread Richard Biener
On Tue, 4 Mar 2014, Richard Biener wrote: > On Tue, 4 Mar 2014, Jan-Benedict Glaw wrote: > > > On Tue, 2014-03-04 12:22:12 +0100, Richard Biener wrote: > > > > > > We're doing the LTO bytecode version check only for two section > > > types at the moment - specifically _not_ for the first sectio

Re: [PATCH] Properly do the LTO bytecode version check

2014-03-04 Thread Richard Biener
On Tue, 4 Mar 2014, Jan-Benedict Glaw wrote: > On Tue, 2014-03-04 12:22:12 +0100, Richard Biener wrote: > > > > We're doing the LTO bytecode version check only for two section > > types at the moment - specifically _not_ for the first section > > we read. Which causes us to crash instead of rep

Re: [PATCH] Properly do the LTO bytecode version check

2014-03-04 Thread Jan-Benedict Glaw
On Tue, 2014-03-04 12:22:12 +0100, Richard Biener wrote: > > We're doing the LTO bytecode version check only for two section > types at the moment - specifically _not_ for the first section > we read. Which causes us to crash instead of reporting a > version mismatch ... > > Fixed by doing the

[PATCH] Properly do the LTO bytecode version check

2014-03-04 Thread Richard Biener
We're doing the LTO bytecode version check only for two section types at the moment - specifically _not_ for the first section we read. Which causes us to crash instead of reporting a version mismatch ... Fixed by doing the version check in the most appropriate place. LTO bootstrapped on x86_64