Re: [PATCH] PR77359: Properly align local variables in functions calling alloca.

2016-11-15 Thread Dominik Vogt
On Fri, Nov 11, 2016 at 02:17:58PM -0600, Segher Boessenkool wrote: > On Fri, Nov 11, 2016 at 09:58:21AM +0100, Dominik Vogt wrote: > > > You say it needs more testing -- what testing? > > > > Regression testing on AIX (David has done this in reply to the > > original message), possibly also on 32

Re: [PATCH] PR77359: Properly align local variables in functions calling alloca.

2016-11-11 Thread Segher Boessenkool
On Fri, Nov 11, 2016 at 09:58:21AM +0100, Dominik Vogt wrote: > > You say it needs more testing -- what testing? > > Regression testing on AIX (David has done this in reply to the > original message), possibly also on 32-Bit Power, if that is a > reasonable target. It is. I'll test powerpc64-lin

Re: [PATCH] PR77359: Properly align local variables in functions calling alloca.

2016-11-11 Thread Dominik Vogt
C_OFFSET): Likewise. * config/rs6000/aix.h (STARTING_FRAME_OFFSET, STACK_DYNAMIC_OFFSET): Copy AIX specific versions of the rs6000.h macros to aix.h. >From faae30210f584bba92ab96aac479ae8f253e59b7 Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Fri, 28 Oct 2016 12:59:55 +0100

Re: [PATCH] PR77359: Properly align local variables in functions calling alloca.

2016-11-10 Thread David Edelsohn
On Thu, Nov 10, 2016 at 6:47 PM, Dominik Vogt wrote: > On Thu, Nov 03, 2016 at 11:40:44AM +0100, Dominik Vogt wrote: >> The attached patch fixes the stack layout problems on AIX and >> Power as described here: >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77359 >> >> The patch has been boot

Re: [PATCH] PR77359: Properly align local variables in functions calling alloca.

2016-11-10 Thread Segher Boessenkool
On Fri, Nov 11, 2016 at 12:47:02AM +0100, Dominik Vogt wrote: > On Thu, Nov 03, 2016 at 11:40:44AM +0100, Dominik Vogt wrote: > > The attached patch fixes the stack layout problems on AIX and > > Power as described here: > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77359 > > > > The pat

Re: [PATCH] PR77359: Properly align local variables in functions calling alloca.

2016-11-10 Thread Dominik Vogt
c27281eef2 Mon Sep 17 00:00:00 2001 > From: Dominik Vogt > Date: Fri, 28 Oct 2016 12:59:55 +0100 > Subject: [PATCH] PR77359: Properly align local variables in functions > calling alloca. > > See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77359 for a discussion of the > proble

Re: [PATCH] PR77359: Properly align local variables in functions calling alloca.

2016-11-03 Thread David Edelsohn
[Please cc me and Segher on PowerPC / AIX patches.] I bootstrapped successfully with the patch and ran the testsuite. Without patch: https://gcc.gnu.org/ml/gcc-testresults/2016-11/msg00186.html With patch: https://gcc.gnu.org/ml/gcc-testresults/2016-11/msg00233.html Not exactly the same revisio

[PATCH] PR77359: Properly align local variables in functions calling alloca.

2016-11-03 Thread Dominik Vogt
the rs6000.h macros to aix.h. >From bd36042fd82e29204d2f10c180b9e7c27281eef2 Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Fri, 28 Oct 2016 12:59:55 +0100 Subject: [PATCH] PR77359: Properly align local variables in functions calling alloca. See https://gcc.gnu.org/bugzilla/show_bug.cgi