Re: [PATCH] PR preprocessor/7263 - Avoid pedantic warnings on system headers macro tokens

2012-05-15 Thread Jason Merrill
OK. Jason

Re: [PATCH] PR preprocessor/7263 - Avoid pedantic warnings on system headers macro tokens

2012-05-14 Thread Jason Merrill
On 05/10/2012 01:53 PM, Dodji Seketeli wrote: + if (found_decl_spec && ds != ds_last) Do we still need found_decl_spec? + if (decl_spec_seq_has_spec_p (&decl_specifiers, ds_inline)) permerror (input_location, "explicit instantiation shall not use"

Re: [PATCH] PR preprocessor/7263 - Avoid pedantic warnings on system headers macro tokens

2012-05-04 Thread Jason Merrill
On 05/04/2012 12:32 PM, Dodji Seketeli wrote: Jason Merrill writes: + decl_specs->locations[cpdw_builtin_type_spec] = location; if (!decl_specs->type) { decl_specs->type = type_spec; decl_specs->type_definition_p = false; - decl_specs->type_loca

Re: [PATCH] PR preprocessor/7263 - Avoid pedantic warnings on system headers macro tokens

2012-05-04 Thread Dodji Seketeli
Jason Merrill writes: >> + decl_specs->locations[cpdw_builtin_type_spec] = location; >>if (!decl_specs->type) >> { >>decl_specs->type = type_spec; >>decl_specs->type_definition_p = false; >> - decl_specs->type_location = location; >> + decl_specs->locat

Re: [PATCH] PR preprocessor/7263 - Avoid pedantic warnings on system headers macro tokens

2012-05-04 Thread Jason Merrill
It seems like for most of the declspecs, having both the location and a flag/count is unnecessary; instead of checking the flag, we can check whether the location is set. That won't work for the "long long long" check, but it should work for the others. You'll need to change _check_decl_spec