Re: [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro

2020-04-01 Thread Hans-Peter Nilsson
On Wed, 1 Apr 2020, Martin Li?ka wrote: > On 4/1/20 7:01 AM, Hans-Peter Nilsson wrote: > > On Tue, 31 Mar 2020, Maciej W. Rozycki wrote: > > > Correct an issue with GCC commit 906b3eb9df6c ("Improve endianess > > > detection.") and fix a typo in the __BYTE_ORDER fallback macro check > > > that cau

Re: [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro

2020-04-01 Thread Maciej W. Rozycki
On Wed, 1 Apr 2020, Martin Liška wrote: > > commit 142d68f50b48309f48e34fc1d9d6dbbeecfde684 > > Author: Martin Liska > > AuthorDate: Wed Apr 1 09:37:37 2020 +0200 > > Commit: Martin Liska > > CommitDate: Wed Apr 1 09:37:37 2020 +0200 > > > > You're still listed as the author of the chan

Re: [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro

2020-04-01 Thread Martin Liška
On 4/1/20 5:59 PM, Maciej W. Rozycki wrote: On Wed, 1 Apr 2020, Martin Liška wrote: I've just installed the patch. @H.J. Can you please pull it to bintuils? Why didn't you use the commit as I published it Because it didn't fit my script that takes changelog entries and moves that to the

Re: [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro

2020-04-01 Thread Maciej W. Rozycki
On Wed, 1 Apr 2020, Martin Liška wrote: > >> I've just installed the patch. > >> @H.J. Can you please pull it to bintuils? > > > > Why didn't you use the commit as I published it > > Because it didn't fit my script that takes changelog entries > and moves that to the corresponding ChangeLog fi

Re: [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro

2020-04-01 Thread Martin Liška
On 4/1/20 12:04 PM, Maciej W. Rozycki wrote: On Wed, 1 Apr 2020, Martin Liška wrote: NB if posting as an attachment please try matching the message subject with the change heading as otherwise it takes a lot of effort to track the patch submission corresponding to a given commit. I see you

Re: [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro

2020-04-01 Thread Maciej W. Rozycki
On Wed, 1 Apr 2020, Martin Liška wrote: > > NB if posting as an attachment please try matching the message subject > > with the change heading as otherwise it takes a lot of effort to track the > > patch submission corresponding to a given commit. > > I see your point, but note that sometimes a

Re: [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro

2020-04-01 Thread Martin Liška
On 4/1/20 11:55 AM, Maciej W. Rozycki wrote: On Wed, 1 Apr 2020, Martin Liška wrote: OK to apply this hopefully obvious fix to GCC and then merge to binutils? I've just installed the patch. @H.J. Can you please pull it to bintuils? Why didn't you use the commit as I published it Beca

Re: [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro

2020-04-01 Thread Maciej W. Rozycki
On Wed, 1 Apr 2020, Martin Liška wrote: > > OK to apply this hopefully obvious fix to GCC and then merge to binutils? > > I've just installed the patch. > @H.J. Can you please pull it to bintuils? Why didn't you use the commit as I published it and also assumed authorship of my change? I fe

Re: [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro

2020-04-01 Thread Martin Liška
On 4/1/20 7:01 AM, Hans-Peter Nilsson wrote: On Tue, 31 Mar 2020, Maciej W. Rozycki wrote: Correct an issue with GCC commit 906b3eb9df6c ("Improve endianess detection.") and fix a typo in the __BYTE_ORDER fallback macro check that causes compilation errors like: .../include/plugin-api.h:162:2:

Re: [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro

2020-04-01 Thread Martin Liška
On 3/31/20 3:27 PM, Maciej W. Rozycki wrote: Correct an issue with GCC commit 906b3eb9df6c ("Improve endianess detection.") and fix a typo in the __BYTE_ORDER fallback macro check that causes compilation errors like: .../include/plugin-api.h:162:2: error: #error "Could not detect architecture e

Re: [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro

2020-04-01 Thread Richard Biener via Gcc-patches
On Tue, Mar 31, 2020 at 3:28 PM Maciej W. Rozycki wrote: > > Correct an issue with GCC commit 906b3eb9df6c ("Improve endianess > detection.") and fix a typo in the __BYTE_ORDER fallback macro check > that causes compilation errors like: > > .../include/plugin-api.h:162:2: error: #error "Could not

Re: [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro

2020-03-31 Thread Hans-Peter Nilsson
On Tue, 31 Mar 2020, Maciej W. Rozycki wrote: > Correct an issue with GCC commit 906b3eb9df6c ("Improve endianess > detection.") and fix a typo in the __BYTE_ORDER fallback macro check > that causes compilation errors like: > > .../include/plugin-api.h:162:2: error: #error "Could not detect archite

[PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro

2020-03-31 Thread Maciej W. Rozycki
Correct an issue with GCC commit 906b3eb9df6c ("Improve endianess detection.") and fix a typo in the __BYTE_ORDER fallback macro check that causes compilation errors like: .../include/plugin-api.h:162:2: error: #error "Could not detect architecture endianess" on systems that do not provide the