Re: [PATCH] PHIOPT: Fix minmax_replacement for three way

2023-09-26 Thread Richard Biener
On Thu, Sep 21, 2023 at 10:10 AM Andrew Pinski wrote: > > So when diamond bb support was added to minmax_replacement in > r13-1950-g9bb19e143cfe, > the code was not expecting the alt_middle_bb not to exist if it was empty > (for threeway_p). > So when factor_out_conditional_conversion was used t

Re: [PATCH] PHIOPT: Fix minmax_replacement for three way

2023-09-26 Thread Richard Biener
On Sat, Sep 23, 2023 at 2:55 AM Andrew Pinski wrote: > > So when diamond bb support was added to minmax_replacement in > r13-1950-g9bb19e143cfe, > the code was not expecting the alt_middle_bb not to exist if it was empty > (for threeway_p). > So when factor_out_conditional_conversion was used to

[PATCH] PHIOPT: Fix minmax_replacement for three way

2023-09-22 Thread Andrew Pinski
So when diamond bb support was added to minmax_replacement in r13-1950-g9bb19e143cfe, the code was not expecting the alt_middle_bb not to exist if it was empty (for threeway_p). So when factor_out_conditional_conversion was used to factor out conversions, it turns out the assumption for alt_midd

[PATCH] PHIOPT: Fix minmax_replacement for three way

2023-09-21 Thread Andrew Pinski
So when diamond bb support was added to minmax_replacement in r13-1950-g9bb19e143cfe, the code was not expecting the alt_middle_bb not to exist if it was empty (for threeway_p). So when factor_out_conditional_conversion was used to factor out conversions, it turns out the assumption for alt_midd