Re: [WIP] [PR fortran/72741] Rework Fortran OpenACC routine clause handling (was: [PATCH] OpenACC routines in fortran modules)

2016-08-11 Thread Jakub Jelinek
On Thu, Aug 11, 2016 at 06:26:50PM +0200, Thomas Schwinge wrote: > > > --- gcc/fortran/gfortran.h > > > +++ gcc/fortran/gfortran.h > > > > /* Symbol attribute structure. */ > > > -typedef struct > > > +typedef struct symbol_attribute > > > { > > > While symbol_attribute is already bloated, I d

Re: [WIP] [PR fortran/72741] Rework Fortran OpenACC routine clause handling (was: [PATCH] OpenACC routines in fortran modules)

2016-08-11 Thread Thomas Schwinge
Hi! As Cesar asked for it, there is now a Git branch tschwinge/omp/pr72741-wip containing these changes (plus some other pending changes that I didn't single out at this time), at . (I expect it does, but I didn'

Re: [WIP] [PR fortran/72741] Rework Fortran OpenACC routine clause handling (was: [PATCH] OpenACC routines in fortran modules)

2016-08-11 Thread Jakub Jelinek
On Thu, Aug 11, 2016 at 05:18:43PM +0200, Thomas Schwinge wrote: > --- gcc/fortran/gfortran.h > +++ gcc/fortran/gfortran.h > @@ -729,7 +839,7 @@ ext_attr_t; > extern const ext_attr_t ext_attr_list[]; > > /* Symbol attribute structure. */ > -typedef struct > +typedef struct symbol_attribute >

[WIP] [PR fortran/72741] Rework Fortran OpenACC routine clause handling (was: [PATCH] OpenACC routines in fortran modules)

2016-08-11 Thread Thomas Schwinge
Hi! This is still hacky and WIP; posting for Cesar and Tobias to have a look. I'm still not too much of a Fortran person. ;-) On Fri, 1 Jul 2016 13:40:58 -0700, Cesar Philippidis wrote: > It turns out that the acc routine parallelism isn't being recorded in > fortran .mod files. This is a prob

Re: [PATCH] OpenACC routines in fortran modules

2016-07-28 Thread Cesar Philippidis
On 07/28/2016 02:55 AM, Tobias Burnus wrote: > Cesar Philippidis wrote: >> It turns out that the acc routine parallelism isn't being recorded in >> fortran .mod files. This is a problem because then the ME can't validate >> if a routine has compatible parallelism with the call site. > > Nothing a

Re: [PATCH] OpenACC routines in fortran modules

2016-07-28 Thread Tobias Burnus
Cesar Philippidis wrote: > It turns out that the acc routine parallelism isn't being recorded in > fortran .mod files. This is a problem because then the ME can't validate > if a routine has compatible parallelism with the call site. Nothing against saving such information in .mod files. However,

[PATCH] OpenACC routines in fortran modules

2016-07-01 Thread Cesar Philippidis
It turns out that the acc routine parallelism isn't being recorded in fortran .mod files. This is a problem because then the ME can't validate if a routine has compatible parallelism with the call site. This patch does two things: 1. Encode gang, worker, vector and seq level parallelism in module