[WIP] OpenACC 'acc_attach*', 'acc_detach*' runtime library routines (was: [PATCH] OpenACC 2.6 manual deep copy support (attach/detach))

2019-12-17 Thread Thomas Schwinge
Hi! On 2019-12-17T12:28:32+0100, Thomas Schwinge wrote: > As a first step, can you please split out just the code required to make > the OpenACC 'acc_attach*', 'acc_detach*' runtime library routines work? I've now simply done this myself (that is, code extraction from Julian's patch, not any dev

In 'libgomp/target.c', 'struct splay_tree_key_s', use 'struct splay_tree_aux' for infrequently-used or API-specific data (was: [PATCH] OpenACC 2.6 manual deep copy support (attach/detach))

2019-12-17 Thread Thomas Schwinge
Hi Jakub! On 2019-11-06T18:43:39+, Julian Brown wrote: > In particular, [a new big patch] incorporates the idea [...] > relating to adding the new "attach_count" field to the memory-mapping > splay tree key type without growing that structure in the common case > (i.e. when structure componen

Re: [PATCH] OpenACC 2.6 manual deep copy support (attach/detach)

2019-12-17 Thread Thomas Schwinge
Hi Julian! As a first step, can you please split out just the code required to make the OpenACC 'acc_attach*', 'acc_detach*' runtime library routines work? Assuming there were no other defects in libgomp, whould this already make the 'libgomp.oacc-c-c++-common/deep-copy-3.c', 'libgomp.oacc-c-c++-

Re: [PATCH] OpenACC 2.6 manual deep copy support (attach/detach)

2019-11-25 Thread Tobias Burnus
Hi Julian, On 11/23/19 12:42 AM, Julian Brown wrote: gcc/fortran/ * trans-expr.c (gfc_auto_dereference_var): New function, broken out of... […] +gfc_auto_dereference_var (location_t loc, gfc_symbol *sym, tree var, + bool descriptor_

Re: [PATCH] OpenACC 2.6 manual deep copy support (attach/detach)

2019-10-18 Thread Thomas Schwinge
Hi! While reviewing <20191003163505.49997-2-julian@codesourcery.com">http://mid.mail-archive.com/20191003163505.49997-2-julian@codesourcery.com> "OpenACC reference count overhaul", I've just now stumbled over one thing that originally was designed here: On 2018-12-10T19:41:37+, Julian Brown

Re: [PATCH] OpenACC 2.6 manual deep copy support (attach/detach)

2018-12-18 Thread Jakub Jelinek
On Fri, Dec 14, 2018 at 07:00:30PM +, Julian Brown wrote: > OpenACC 2.6 manual deep copy support (attach/detach) > > gcc/c-family/ > * c-pragma.h (pragma_omp_clause): Add PRAGMA_OACC_CLAUSE_ATTACH, > PRAGMA_OACC_CLAUSE_DETACH. and instead of , ? > --- a/gcc/c-family/

Re: [PATCH] OpenACC 2.6 manual deep copy support (attach/detach)

2018-12-13 Thread Jakub Jelinek
On Mon, Dec 10, 2018 at 07:41:37PM +, Julian Brown wrote: > @@ -11870,7 +11874,8 @@ c_parser_oacc_wait_list (c_parser *parser, location_t > clause_loc, tree list) > static tree > c_parser_omp_variable_list (c_parser *parser, > location_t clause_loc, > -

Re: [PATCH] OpenACC 2.6 manual deep copy support (attach/detach)

2018-12-07 Thread Jakub Jelinek
On Fri, Nov 30, 2018 at 03:41:09AM -0800, Julian Brown wrote: > gcc/c-family/ > * c-pragma.h (pragma_omp_clause): Add PRAGMA_OACC_CLAUSE_ATTACH, > PRAGMA_OACC_CLAUSE_DETACH. ... > @@ -11804,9 +11808,12 @@ c_parser_omp_variable_list (c_parser *parser, > case OMP_CLAUSE_MA

Re: [PATCH] OpenACC 2.6 manual deep copy support (attach/detach)

2018-12-03 Thread Julian Brown
On Fri, 30 Nov 2018 03:41:09 -0800 Julian Brown wrote: > This is a new version of the patch incorporating > several improvements/bugfixes made on the og8 branch: I released I forgot (again!) to incorporate the changes suggested by Bernhard in: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00861