Re: [PATCH] Move rust_{is_mangled,demangle_sym} to a private libiberty header.

2019-07-18 Thread Jakub Jelinek
On Thu, Jul 18, 2019 at 07:04:05AM -0700, Ian Lance Taylor wrote: > >> On Mon, Jun 3, 2019, at 7:23 AM, Ian Lance Taylor wrote: > >> > On Sat, Jun 1, 2019 at 7:15 AM Eduard-Mihai Burtescu > >> > wrote: > >> > > > >> > > 2019-06-01 Eduard-Mihai Burtescu > >> > > include/ChangeLog: > >> > > * dema

Re: [PATCH] Move rust_{is_mangled,demangle_sym} to a private libiberty header.

2019-07-18 Thread Ian Lance Taylor
"Eduard-Mihai Burtescu" writes: > Pinging this again - while it's a tiny change, I want it to land > before I submit anything else in this area. > Also, I forgot to mention I have no commit access. > > Original submission can be found at > https://gcc.gnu.org/ml/gcc-patches/2019-06/msg6.html.

Re: [PATCH] Move rust_{is_mangled,demangle_sym} to a private libiberty header.

2019-07-18 Thread Eduard-Mihai Burtescu
Pinging this again - while it's a tiny change, I want it to land before I submit anything else in this area. Also, I forgot to mention I have no commit access. Original submission can be found at https://gcc.gnu.org/ml/gcc-patches/2019-06/msg6.html. Thanks, - Eddy B. On Wed, Jun 26, 2019,

Re: [PATCH] Move rust_{is_mangled,demangle_sym} to a private libiberty header.

2019-06-26 Thread Eduard-Mihai Burtescu
Bootstrapped and tested on x86_64-unknown-linux-gnu. (Apologies for the delay, while I was able to run libiberty tests back when I submitted the patch, I wanted to make sure I can run the whole GCC testsuite, especially for more significant future contributions, so I had to wait until I had the

Re: [PATCH] Move rust_{is_mangled,demangle_sym} to a private libiberty header.

2019-06-26 Thread Eduard-Mihai Burtescu
Hi Mark, Valgrind is definitely on my upstreaming list, alongside GDB, LLDB and Linux perf. You can see the preliminary version here: https://gist.github.com/eddyb/c41a69378750a433767cf53fe2316768 (do not use it yet, I still want to tweak it a bit more before upstreaming it, soon, and I want

Re: [PATCH] Move rust_{is_mangled,demangle_sym} to a private libiberty header.

2019-06-04 Thread Mark Wielaard
On Sat, 2019-06-01 at 17:14 +0300, Eduard-Mihai Burtescu wrote: > When libiberty/rust-demangle.c was initially added, its two exports, > rust_is_mangled and rust_demangle_sym, made it to include/demangle.h. > However, these two functions are merely implementation details of > cplus_demangle and rus

Re: [PATCH] Move rust_{is_mangled,demangle_sym} to a private libiberty header.

2019-06-02 Thread Ian Lance Taylor via gcc-patches
On Sat, Jun 1, 2019 at 7:15 AM Eduard-Mihai Burtescu wrote: > > 2019-06-01 Eduard-Mihai Burtescu > include/ChangeLog: > * demangle.h (rust_is_mangled): Move to libiberty/rust-demangle.h. > (rust_demangle_sym): Move to libiberty/rust-demangle.h. > libiberty/ChangeLog: > *

[PATCH] Move rust_{is_mangled,demangle_sym} to a private libiberty header.

2019-06-01 Thread Eduard-Mihai Burtescu
When libiberty/rust-demangle.c was initially added, its two exports, rust_is_mangled and rust_demangle_sym, made it to include/demangle.h. However, these two functions are merely implementation details of cplus_demangle and rust_demangle, only the latter should be public. This is becoming a proble