Re: [PATCH] More value_range API cleanup

2018-11-13 Thread Aldy Hernandez
On 11/13/18 8:58 AM, Richard Biener wrote: On Tue, 13 Nov 2018, Aldy Hernandez wrote: On 11/13/18 3:07 AM, Richard Biener wrote: On Tue, 13 Nov 2018, Aldy Hernandez wrote: The tricky part starts in the prologue for if (vr0->undefined_p ()) { vr0->deep_copy (vr1);

Re: [PATCH] More value_range API cleanup

2018-11-13 Thread Richard Biener
On Tue, 13 Nov 2018, Aldy Hernandez wrote: > On 11/13/18 3:07 AM, Richard Biener wrote: > > On Tue, 13 Nov 2018, Aldy Hernandez wrote: > > > > > > > > > > The tricky part starts in the prologue for > > > > > > > > > > if (vr0->undefined_p ()) > > > > > { > > > > > vr0->deep_co

Re: [PATCH] More value_range API cleanup

2018-11-13 Thread Aldy Hernandez
On 11/13/18 3:07 AM, Richard Biener wrote: On Tue, 13 Nov 2018, Aldy Hernandez wrote: The tricky part starts in the prologue for if (vr0->undefined_p ()) { vr0->deep_copy (vr1); return; } but yes, we probably can factor out a bit more common code here. I'll

Re: [PATCH] More value_range API cleanup

2018-11-13 Thread Richard Biener
On Tue, 13 Nov 2018, Aldy Hernandez wrote: > > > > The tricky part starts in the prologue for > > > > > >if (vr0->undefined_p ()) > > > { > > >vr0->deep_copy (vr1); > > >return; > > > } > > > > > > but yes, we probably can factor out a bit more common code > > > he

Re: [PATCH] More value_range API cleanup

2018-11-13 Thread Aldy Hernandez
The tricky part starts in the prologue for if (vr0->undefined_p ()) { vr0->deep_copy (vr1); return; } but yes, we probably can factor out a bit more common code here. I'll see to followup with more minor cleanups this week (noticed a few details myself). Like thi

Re: [PATCH] More value_range API cleanup

2018-11-12 Thread Richard Biener
On Tue, 13 Nov 2018, Richard Biener wrote: > On Mon, 12 Nov 2018, Aldy Hernandez wrote: > > > On 11/12/18 7:12 AM, Richard Biener wrote: > > > > > > This mainly tries to rectify the workaround I put in place for ipa-cp.c > > > needing to build value_range instead of value_range_base for calling

Re: [PATCH] More value_range API cleanup

2018-11-12 Thread Richard Biener
On Mon, 12 Nov 2018, Aldy Hernandez wrote: > On 11/12/18 7:12 AM, Richard Biener wrote: > > > > This mainly tries to rectify the workaround I put in place for ipa-cp.c > > needing to build value_range instead of value_range_base for calling > > extract_range_from_unary_expr. > > > > To make this

Re: [PATCH] More value_range API cleanup

2018-11-12 Thread Aldy Hernandez
On 11/12/18 7:12 AM, Richard Biener wrote: This mainly tries to rectify the workaround I put in place for ipa-cp.c needing to build value_range instead of value_range_base for calling extract_range_from_unary_expr. To make this easier I moved more set_* functions to methods. Then for some reas

[PATCH] More value_range API cleanup

2018-11-12 Thread Richard Biener
This mainly tries to rectify the workaround I put in place for ipa-cp.c needing to build value_range instead of value_range_base for calling extract_range_from_unary_expr. To make this easier I moved more set_* functions to methods. Then for some reason I chose to fix the rathole of equiv bitma