Re: [PATCH] Make hashtab/hash-table elt removal not fail on removing non-existent entry

2019-03-15 Thread Bernhard Reutner-Fischer
On Thu, 14 Mar 2019 10:19:17 +0100 Jakub Jelinek wrote: > On Thu, Mar 14, 2019 at 09:57:27AM +0100, Richard Biener wrote: > > I'd say make it work, thus your patch below is OK. > > Ok, here is an updated patch with some self-tests coverage as well that I'll > bootstrap/regtest. I had the simp

Re: [PATCH] Make hashtab/hash-table elt removal not fail on removing non-existent entry

2019-03-14 Thread Jakub Jelinek
On Thu, Mar 14, 2019 at 09:57:27AM +0100, Richard Biener wrote: > I'd say make it work, thus your patch below is OK. Ok, here is an updated patch with some self-tests coverage as well that I'll bootstrap/regtest. 2019-03-14 Jason Merrill Jakub Jelinek * hash-table.h (rem

Re: [PATCH] Make hashtab/hash-table elt removal not fail on removing non-existent entry

2019-03-14 Thread Richard Biener
On Thu, 14 Mar 2019, Jakub Jelinek wrote: > On Wed, Mar 13, 2019 at 10:08:09PM -0400, Jason Merrill wrote: > > > The following testcase ICEs since my recent cxx_eval_loop_expr changes. > > > The problem is that the Forget saved values of SAVE_EXPRs. inside of the > > > loop can remove SAVE_EXPRs f

[PATCH] Make hashtab/hash-table elt removal not fail on removing non-existent entry

2019-03-14 Thread Jakub Jelinek
On Wed, Mar 13, 2019 at 10:08:09PM -0400, Jason Merrill wrote: > > The following testcase ICEs since my recent cxx_eval_loop_expr changes. > > The problem is that the Forget saved values of SAVE_EXPRs. inside of the > > loop can remove SAVE_EXPRs from new_ctx.values and if that is the last > > iter