Re: [PATCH] LoongArch: Implement scalar isinf, isnormal, and isfinite via fclass

2024-08-15 Thread Xi Ruoyao
On Mon, 2024-07-15 at 15:53 +0800, Lulu Cheng wrote: > g++.dg/opt/pr107569. C and range-sincos.c vrp-float-abs-1.c is the > same > issue, right? > > And I have no objection to code modifications. But I think it's better > to wait until this builtin > > function is fixed. Pushed r15-2931. The r

Re: [PATCH] LoongArch: Implement scalar isinf, isnormal, and isfinite via fclass

2024-07-22 Thread Xi Ruoyao
On Sun, 2024-07-21 at 22:46 -0700, Andrew Pinski wrote: > On Sun, Jul 21, 2024 at 3:57 AM Xi Ruoyao wrote: > > > > On Mon, 2024-07-15 at 15:53 +0800, Lulu Cheng wrote: > > > Hi, > > > > > > g++.dg/opt/pr107569.C and range-sincos.c vrp-float-abs-1.c is the same > > > issue, right? > > > > > > An

Re: [PATCH] LoongArch: Implement scalar isinf, isnormal, and isfinite via fclass

2024-07-21 Thread Andrew Pinski
On Sun, Jul 21, 2024 at 3:57 AM Xi Ruoyao wrote: > > On Mon, 2024-07-15 at 15:53 +0800, Lulu Cheng wrote: > > Hi, > > > > g++.dg/opt/pr107569.C and range-sincos.c vrp-float-abs-1.c is the same > > issue, right? > > > > And I have no objection to code modifications. But I think it's better > > to w

Re: [PATCH] LoongArch: Implement scalar isinf, isnormal, and isfinite via fclass

2024-07-21 Thread Xi Ruoyao
On Mon, 2024-07-15 at 15:53 +0800, Lulu Cheng wrote: > Hi, > > g++.dg/opt/pr107569.C and range-sincos.c vrp-float-abs-1.c is the same > issue, right? > > And I have no objection to code modifications. But I think it's better > to wait until this builtin > > function is fixed. Oops https://gcc.

Re: [PATCH] LoongArch: Implement scalar isinf, isnormal, and isfinite via fclass

2024-07-15 Thread Lulu Cheng
在 2024/7/11 下午7:45, Xi Ruoyao 写道: Doing so can avoid loading FP constants from the memory. It also partially fixes PR 66462 as fclass does not signal on sNaN. gcc/ChangeLog: * config/loongarch/loongarch.md (extendsidi2): Add ("=r", "f") alternative and use movfr2gr.s for it.

[PATCH] LoongArch: Implement scalar isinf, isnormal, and isfinite via fclass

2024-07-11 Thread Xi Ruoyao
Doing so can avoid loading FP constants from the memory. It also partially fixes PR 66462 as fclass does not signal on sNaN. gcc/ChangeLog: * config/loongarch/loongarch.md (extendsidi2): Add ("=r", "f") alternative and use movfr2gr.s for it. The spec clearly states movfr