Re: [PATCH] LRA: side_effects_p stmts' output is not invariant (PR89721)

2019-10-17 Thread Vladimir Makarov
On 10/17/19 2:09 PM, Segher Boessenkool wrote: On Fri, Mar 15, 2019 at 05:14:48PM -0500, Segher Boessenkool wrote: On Fri, Mar 15, 2019 at 04:25:01PM -0400, Vladimir Makarov wrote: On 2019-03-15 2:30 p.m., Segher Boessenkool wrote: PR89721 shows LRA treating an unspec_volatile's result as inva

Re: [PATCH] LRA: side_effects_p stmts' output is not invariant (PR89721)

2019-10-17 Thread Segher Boessenkool
On Fri, Mar 15, 2019 at 05:14:48PM -0500, Segher Boessenkool wrote: > On Fri, Mar 15, 2019 at 04:25:01PM -0400, Vladimir Makarov wrote: > > On 2019-03-15 2:30 p.m., Segher Boessenkool wrote: > > >PR89721 shows LRA treating an unspec_volatile's result as invariant, > > >which of course isn't correct

Re: [PATCH] LRA: side_effects_p stmts' output is not invariant (PR89721)

2019-03-15 Thread Segher Boessenkool
Hi! On Fri, Mar 15, 2019 at 04:25:01PM -0400, Vladimir Makarov wrote: > On 2019-03-15 2:30 p.m., Segher Boessenkool wrote: > >PR89721 shows LRA treating an unspec_volatile's result as invariant, > >which of course isn't correct. This patch fixes it. > Segher, thank you for fixing this.  The patch

Re: [PATCH] LRA: side_effects_p stmts' output is not invariant (PR89721)

2019-03-15 Thread Vladimir Makarov
On 2019-03-15 2:30 p.m., Segher Boessenkool wrote: PR89721 shows LRA treating an unspec_volatile's result as invariant, which of course isn't correct. This patch fixes it. Segher, thank you for fixing this.  The patch is ok to commit. Question. Is side_effects_p the correct check? Or do we

[PATCH] LRA: side_effects_p stmts' output is not invariant (PR89721)

2019-03-15 Thread Segher Boessenkool
PR89721 shows LRA treating an unspec_volatile's result as invariant, which of course isn't correct. This patch fixes it. Question. Is side_effects_p the correct check? Or do we want to allow PRE_INC etc. here? What about CALL? Segher 2019-04-15 Segher Boessenkool PR rtl-optimiz