Re: [PATCH] Instrument bit field and unaligned accesses for TSAN

2015-01-14 Thread Dmitry Vyukov
Cool! Thanks. Gcc is again ahead of clang :) On Sat, Jan 3, 2015 at 1:11 AM, Jakub Jelinek wrote: > On Fri, Jan 02, 2015 at 11:01:56PM +0100, Bernd Edlinger wrote: >> gcc/ChangeLog: >> 2015-01-02 Bernd Edlinger >> >> Instrument bit field and unaligned accesses for TSAN. >> * sani

Re: [PATCH] Instrument bit field and unaligned accesses for TSAN

2015-01-02 Thread Jakub Jelinek
On Fri, Jan 02, 2015 at 11:01:56PM +0100, Bernd Edlinger wrote: > gcc/ChangeLog: > 2015-01-02 Bernd Edlinger > > Instrument bit field and unaligned accesses for TSAN. > * sanitizer.def (BUILT_IN_TSAN_READ_RANGE): New built-in function. > (BUILT_IN_TSAN_WRITE_RANGE): New built-

RE: [PATCH] Instrument bit field and unaligned accesses for TSAN

2015-01-02 Thread Bernd Edlinger
Hi, On Fri, 2 Jan 2015 22:29:01, Jakub Jelinek wrote: > > On Fri, Jan 02, 2015 at 10:06:29PM +0100, Bernd Edlinger wrote: >> OK, I will do that. >> I removed the __tsan_vptr_update stuff from the patch, for now. > > Guess we should ask Dmitry about that. > >> It will probably be difficult for me

Re: [PATCH] Instrument bit field and unaligned accesses for TSAN

2015-01-02 Thread Jakub Jelinek
On Fri, Jan 02, 2015 at 10:06:29PM +0100, Bernd Edlinger wrote: > OK, I will do that. > I removed the __tsan_vptr_update stuff from the patch, for now. Guess we should ask Dmitry about that. > It will probably be difficult for me to find a test case for this, > because I am not really sure what _

RE: [PATCH] Instrument bit field and unaligned accesses for TSAN

2015-01-02 Thread Bernd Edlinger
On Fri, 2 Jan 2015 20:01:02, Jakub Jelinke wrote: > > On Mon, Dec 29, 2014 at 09:20:57PM +0100, Bernd Edlinger wrote: > >> --- gcc/sanitizer.def (revision 218963) >> +++ gcc/sanitizer.def (working copy) >> @@ -188,6 +188,10 @@ DEF_SANITIZER_BUILTIN(BUILT_IN_TSAN_WRITE8, "__tsa >> BT_FN_VOID_PTR,

Re: [PATCH] Instrument bit field and unaligned accesses for TSAN

2015-01-02 Thread Jakub Jelinek
On Mon, Dec 29, 2014 at 09:20:57PM +0100, Bernd Edlinger wrote: > --- gcc/sanitizer.def (revision 218963) > +++ gcc/sanitizer.def (working copy) > @@ -188,6 +188,10 @@ DEF_SANITIZER_BUILTIN(BUILT_IN_TSAN_WRITE8, "__tsa > BT_FN_VOID_PTR, ATTR_NOTHROW_LEAF_LIST) > DEF_SANITIZER_

[PATCH] Instrument bit field and unaligned accesses for TSAN

2014-12-29 Thread Bernd Edlinger
Hi, I noticed that currently the tsan pass does not instrument bit fileld accesses or unaligned data. Thus some race conditions are not found by the sanitizer. Furthermore the function __tsan_vptr_update is not called with the correct parameters. This patch uses two already existing interfaces