Re: [PATCH] Include gmp.h from system.h to fix PR54659

2012-12-21 Thread Richard Biener
On Fri, 21 Dec 2012, Eric Botcazou wrote: > > The patch looks fine to me (though it's not 100% obvious to me as not only > > system headers are now no longer in extern "C" - which is why I simply > > tried the un-wrapping). So, if you think that's ok please commit it. > > Done. Thanks. Richard

Re: [PATCH] Include gmp.h from system.h to fix PR54659

2012-12-21 Thread Eric Botcazou
> The patch looks fine to me (though it's not 100% obvious to me as not only > system headers are now no longer in extern "C" - which is why I simply > tried the un-wrapping). So, if you think that's ok please commit it. Done. -- Eric Botcazou

Re: [PATCH] Include gmp.h from system.h to fix PR54659

2012-12-21 Thread Richard Biener
On Fri, 21 Dec 2012, Eric Botcazou wrote: > > This runs into issues with Ada which basically does (ugh) > > > > #ifdef __cplusplus > > extern "C" { > > #endif > > > > #include "system.h" > > > > #endif __cplusplus > > } > > #endif > > > > which of course wrecks any system header doing __cplusp

Re: [PATCH] Include gmp.h from system.h to fix PR54659

2012-12-21 Thread Eric Botcazou
> This runs into issues with Ada which basically does (ugh) > > #ifdef __cplusplus > extern "C" { > #endif > > #include "system.h" > > #endif __cplusplus > } > #endif > > which of course wrecks any system header doing __cplusplus > conditional stuff (such as gmp.h including iosfwd). The patch

[PATCH] Include gmp.h from system.h to fix PR54659

2012-12-21 Thread Richard Biener
The following patch includes gmp.h from system.h (where it belongs, as a system header). This makes sure the libintl kludge we put in place with --disable-nls doesn't wreck the gmp header (well, hopefully, earlier fix to be reverted?). This runs into issues with Ada which basically does (ugh) #