Re: [GCC 8] [PATCH] Ignore the clobbered stack pointer in asm statment

2020-09-24 Thread H.J. Lu via Gcc-patches
On Thu, Sep 24, 2020 at 9:48 AM H.J. Lu wrote: > > On Wed, Sep 16, 2020 at 4:47 AM Jakub Jelinek wrote: > > > > On Wed, Sep 16, 2020 at 12:34:50PM +0100, Richard Sandiford wrote: > > > Jakub Jelinek via Gcc-patches writes: > > > > On Mon, Sep 14, 2020 at 08:57:18AM -0700, H.J. Lu via Gcc-patches

[GCC 8] [PATCH] Ignore the clobbered stack pointer in asm statment

2020-09-24 Thread H.J. Lu via Gcc-patches
On Wed, Sep 16, 2020 at 4:47 AM Jakub Jelinek wrote: > > On Wed, Sep 16, 2020 at 12:34:50PM +0100, Richard Sandiford wrote: > > Jakub Jelinek via Gcc-patches writes: > > > On Mon, Sep 14, 2020 at 08:57:18AM -0700, H.J. Lu via Gcc-patches wrote: > > >> Something like this for GCC 8 and 9. > > > >

Re: [PATCH] Ignore the clobbered stack pointer in asm statment

2020-09-16 Thread Jakub Jelinek via Gcc-patches
On Wed, Sep 16, 2020 at 12:34:50PM +0100, Richard Sandiford wrote: > Jakub Jelinek via Gcc-patches writes: > > On Mon, Sep 14, 2020 at 08:57:18AM -0700, H.J. Lu via Gcc-patches wrote: > >> Something like this for GCC 8 and 9. > > > > Guess my preference would be to do this everywhere and then let'

Re: [PATCH] Ignore the clobbered stack pointer in asm statment

2020-09-16 Thread Richard Sandiford
Jakub Jelinek via Gcc-patches writes: > On Mon, Sep 14, 2020 at 08:57:18AM -0700, H.J. Lu via Gcc-patches wrote: >> Something like this for GCC 8 and 9. > > Guess my preference would be to do this everywhere and then let's discuss if > we change the warning into error there or keep it being deprec

Re: [PATCH] Ignore the clobbered stack pointer in asm statment

2020-09-14 Thread H.J. Lu via Gcc-patches
On Mon, Sep 14, 2020 at 10:05 AM Jakub Jelinek wrote: > > On Mon, Sep 14, 2020 at 08:57:18AM -0700, H.J. Lu via Gcc-patches wrote: > > Something like this for GCC 8 and 9. > > Guess my preference would be to do this everywhere and then let's discuss if The same patch also works on master branch.

Re: [PATCH] Ignore the clobbered stack pointer in asm statment

2020-09-14 Thread Jakub Jelinek via Gcc-patches
On Mon, Sep 14, 2020 at 08:57:18AM -0700, H.J. Lu via Gcc-patches wrote: > Something like this for GCC 8 and 9. Guess my preference would be to do this everywhere and then let's discuss if we change the warning into error there or keep it being deprecated. Though, let's see what others want to sa

Re: [PATCH] Ignore the clobbered stack pointer in asm statment

2020-09-14 Thread H.J. Lu via Gcc-patches
On Mon, Sep 14, 2020 at 8:12 AM H.J. Lu wrote: > > On Mon, Sep 14, 2020 at 7:35 AM Jakub Jelinek wrote: > > > > On Sat, Sep 12, 2020 at 10:11:36AM -0700, H.J. Lu via Gcc-patches wrote: > > > Clobbering the stack pointer in asm statment has been deprecated. Adding > > > the stack pointer register

Re: [PATCH] Ignore the clobbered stack pointer in asm statment

2020-09-14 Thread H.J. Lu via Gcc-patches
On Mon, Sep 14, 2020 at 7:35 AM Jakub Jelinek wrote: > > On Sat, Sep 12, 2020 at 10:11:36AM -0700, H.J. Lu via Gcc-patches wrote: > > Clobbering the stack pointer in asm statment has been deprecated. Adding > > the stack pointer register to the clobber list has traditionally had some > > undocume

Re: [PATCH] Ignore the clobbered stack pointer in asm statment

2020-09-14 Thread Jakub Jelinek via Gcc-patches
On Sat, Sep 12, 2020 at 10:11:36AM -0700, H.J. Lu via Gcc-patches wrote: > Clobbering the stack pointer in asm statment has been deprecated. Adding > the stack pointer register to the clobber list has traditionally had some > undocumented and somewhat obscure side-effects, including ICE. Issue >

Re: [PATCH] Ignore the clobbered stack pointer in asm statment

2020-09-12 Thread Florian Weimer
* Jakub Jelinek: > On Sat, Sep 12, 2020 at 07:37:36PM +0200, Florian Weimer wrote: >> * H. J. Lu via Gcc-patches: >> >> > +inform (input_location, "the value of the stack pointer after" >> > +" an % statement must be the same as it was" >> > +" before the statement");

Re: [PATCH] Ignore the clobbered stack pointer in asm statment

2020-09-12 Thread Jakub Jelinek via Gcc-patches
On Sat, Sep 12, 2020 at 07:37:36PM +0200, Florian Weimer wrote: > * H. J. Lu via Gcc-patches: > > > + inform (input_location, "the value of the stack pointer after" > > + " an % statement must be the same as it was" > > + " before the statement"); > > Would it make sen

Re: [PATCH] Ignore the clobbered stack pointer in asm statment

2020-09-12 Thread H.J. Lu via Gcc-patches
On Sat, Sep 12, 2020 at 10:37 AM Florian Weimer wrote: > > * H. J. Lu via Gcc-patches: > > > + inform (input_location, "the value of the stack pointer after" > > + " an % statement must be the same as it was" > > + " before the statement"); > > Would it make sense

Re: [PATCH] Ignore the clobbered stack pointer in asm statment

2020-09-12 Thread Florian Weimer
* H. J. Lu via Gcc-patches: > + inform (input_location, "the value of the stack pointer after" > + " an % statement must be the same as it was" > + " before the statement"); Would it make sense to generate a stronger worded warning when generating asynchronous un

[PATCH] Ignore the clobbered stack pointer in asm statment

2020-09-12 Thread H.J. Lu via Gcc-patches
Clobbering the stack pointer in asm statment has been deprecated. Adding the stack pointer register to the clobber list has traditionally had some undocumented and somewhat obscure side-effects, including ICE. Issue a warning and ignore the clobbered stack pointer in asm statment. gcc/