Re: [PATCH] ICF&SRA: Make ICF and SRA agree on padding

2024-04-08 Thread Martin Jambor
Hello, On Sun, Apr 07 2024, Xi Ruoyao wrote: > On Thu, 2024-04-04 at 23:19 +0200, Martin Jambor wrote: >> The patch has been approved by Honza in Bugzilla. (I hope.  He did write >> it looked reasonable.)  Together with the patch for PR 113907, it has >> passed bootstrap, LTO bootstrap and LTO pro

Re: [PATCH] ICF&SRA: Make ICF and SRA agree on padding

2024-04-07 Thread Xi Ruoyao
On Thu, 2024-04-04 at 23:19 +0200, Martin Jambor wrote: > +/* Given two types in an assignment, return true either if any one cannot be > +   totally scalarized or if they have padding (i.e. not copied bits)  */ > + > +bool > +sra_total_scalarization_would_copy_same_data_p (tree t1, tree t2) > +{ >

Re: [PATCH] ICF&SRA: Make ICF and SRA agree on padding

2024-04-07 Thread Xi Ruoyao
On Thu, 2024-04-04 at 23:19 +0200, Martin Jambor wrote: > The patch has been approved by Honza in Bugzilla. (I hope.  He did write > it looked reasonable.)  Together with the patch for PR 113907, it has > passed bootstrap, LTO bootstrap and LTO profiledbootstrap and testing on > x86_64-linux and bo

[PATCH] ICF&SRA: Make ICF and SRA agree on padding

2024-04-04 Thread Martin Jambor
Hi, PR 113359 shows that (at least with -fno-strict-aliasing) ICF can unify two functions which copy an aggregate type of the same size but then SRA, through its total scalarization, can copy the aggregate by pieces, skipping paddding, but the padding was not the same in the two original functions