Re: [PATCH] Handle fancy_abort before diagnostic initialization [PR98586]

2021-01-14 Thread David Malcolm via Gcc-patches
On Tue, 2021-01-12 at 08:44 +0100, Richard Biener wrote: > On Mon, Jan 11, 2021 at 10:57 PM David Malcolm via Gcc-patches > wrote: > > If fancy_abort is called before the diagnostic subsystem is > > initialized, > > internal_error will crash internally in a way that prevents a > > useful > > messa

Re: [PATCH] Handle fancy_abort before diagnostic initialization [PR98586]

2021-01-11 Thread Richard Biener via Gcc-patches
On Mon, Jan 11, 2021 at 10:57 PM David Malcolm via Gcc-patches wrote: > > If fancy_abort is called before the diagnostic subsystem is initialized, > internal_error will crash internally in a way that prevents a useful > message reaching the user. > > This can happen with libgccjit in the case of g

[PATCH] Handle fancy_abort before diagnostic initialization [PR98586]

2021-01-11 Thread David Malcolm via Gcc-patches
If fancy_abort is called before the diagnostic subsystem is initialized, internal_error will crash internally in a way that prevents a useful message reaching the user. This can happen with libgccjit in the case of gcc_assert failures that occur outside of the libgccjit mutex that guards the rest