Re: [PATCH] Fortran: improve checking of substring bounds [PR119118]

2025-03-11 Thread Steve Kargl
On Thu, Mar 06, 2025 at 10:49:08PM +0100, Harald Anlauf wrote: > > Thanks for the speedy review! > It was a bit easier than normal. After I submitted the PR, I started to poke around in fortran/resolve.cc to see if I could deal with the issue. I saw that you grab the PR last night, and left yo

Re: [PATCH] Fortran: improve checking of substring bounds [PR119118]

2025-03-07 Thread Steve Kargl
On Thu, Mar 06, 2025 at 10:04:08PM +0100, Harald Anlauf wrote: > > this patch fixes an interesting regression that prevented substring > bounds checks from being generated if the substring start was not a > variable, but rather a constant or an expression. > > The fix I chose turned out to be a l

Re: [PATCH] Fortran: improve checking of substring bounds [PR119118]

2025-03-06 Thread Harald Anlauf
Hi Steve, Am 06.03.25 um 22:32 schrieb Steve Kargl: On Thu, Mar 06, 2025 at 10:04:08PM +0100, Harald Anlauf wrote: this patch fixes an interesting regression that prevented substring bounds checks from being generated if the substring start was not a variable, but rather a constant or an expre

[PATCH] Fortran: improve checking of substring bounds [PR119118]

2025-03-06 Thread Harald Anlauf
: [PATCH] Fortran: improve checking of substring bounds [PR119118] After the fix for pr98490 no substring bounds check was generated if the substring start was not a variable. While the purpose of that fix was to suppress a premature check before implied-do indices were substituted, this prevented a