Re: [PATCH] Fix up undefined signed overflows in FIXED_SSNEG (PR libgcc/55451)

2012-12-11 Thread Ian Lance Taylor
On Tue, Dec 11, 2012 at 7:07 AM, Jakub Jelinek wrote: > > 2012-12-11 Jakub Jelinek > > PR libgcc/55451 > * fixed-bit.c (FIXED_SSADD, FIXED_USADD, FIXED_SSSUB, FIXED_USSUB, > FIXED_SSNEG): Avoid undefined signed overflows. This is OK. Thanks. Ian

Re: [PATCH] Fix up undefined signed overflows in FIXED_SSNEG (PR libgcc/55451)

2012-12-11 Thread Jakub Jelinek
On Tue, Dec 11, 2012 at 06:52:38AM -0800, Ian Lance Taylor wrote: > I presume that the intent of the obfuscation is to make SSNEG look > exactly like SSSUB. And SSSUB appears to have the exact problems that > you are fixing here. So I think you ought to fix both the same way. Ugh, I was hoping f

Re: [PATCH] Fix up undefined signed overflows in FIXED_SSNEG (PR libgcc/55451)

2012-12-11 Thread Ian Lance Taylor
On Tue, Dec 11, 2012 at 4:55 AM, Jakub Jelinek wrote: > > This routine, besides aspiring to win obfuscated C contest (not trying to > address that) contains two undefined signed overflows, which presumably > show up in arm testing. One overflow is on z = x - y; line, > where the x looks just like

[PATCH] Fix up undefined signed overflows in FIXED_SSNEG (PR libgcc/55451)

2012-12-11 Thread Jakub Jelinek
Hi! This routine, besides aspiring to win obfuscated C contest (not trying to address that) contains two undefined signed overflows, which presumably show up in arm testing. One overflow is on z = x - y; line, where the x looks just like obfuscation (it is always 0), for input equal to INT_MIN bi