Re: [PATCH] Fix up sink select_best_block (PR tree-optimization/91355)

2019-11-21 Thread Jan Hubicka
> Hi! > > This patch doesn't fix the actual bug somewhere else, where inserting > stmts on the edge between resx and corresponding landing pad confuses > ehcleanup2, but attempts to restore previous behavior in the heuristics, > which is IMHO desirable too (and makes the bug latent). > r254698 cha

Re: [PATCH] Fix up sink select_best_block (PR tree-optimization/91355)

2019-11-21 Thread Richard Biener
On Thu, 21 Nov 2019, Jakub Jelinek wrote: > Hi! > > This patch doesn't fix the actual bug somewhere else, where inserting > stmts on the edge between resx and corresponding landing pad confuses > ehcleanup2, but attempts to restore previous behavior in the heuristics, > which is IMHO desirable to

[PATCH] Fix up sink select_best_block (PR tree-optimization/91355)

2019-11-21 Thread Jakub Jelinek
Hi! This patch doesn't fix the actual bug somewhere else, where inserting stmts on the edge between resx and corresponding landing pad confuses ehcleanup2, but attempts to restore previous behavior in the heuristics, which is IMHO desirable too (and makes the bug latent). r254698 changed: if (b