Re: [PATCH] Fix the x86 *_doubleword_mask* patterns (PR target/85582)

2018-05-02 Thread Jakub Jelinek
On Wed, May 02, 2018 at 10:09:22AM +0200, Uros Bizjak wrote: > On Wed, May 2, 2018 at 10:02 AM, Jakub Jelinek wrote: > > On Wed, May 02, 2018 at 09:50:07AM +0200, Uros Bizjak wrote: > >> > 2018-05-02 Jakub Jelinek > >> > > >> > PR target/85582 > >> > * config/i386/i386.md (*ashl

Re: [PATCH] Fix the x86 *_doubleword_mask* patterns (PR target/85582)

2018-05-02 Thread Uros Bizjak
On Wed, May 2, 2018 at 10:02 AM, Jakub Jelinek wrote: > On Wed, May 02, 2018 at 09:50:07AM +0200, Uros Bizjak wrote: >> > 2018-05-02 Jakub Jelinek >> > >> > PR target/85582 >> > * config/i386/i386.md (*ashl3_doubleword_mask, >> > *ashl3_doubleword_mask_1, *3_doubleword_m

Re: [PATCH] Fix the x86 *_doubleword_mask* patterns (PR target/85582)

2018-05-02 Thread Jakub Jelinek
On Wed, May 02, 2018 at 09:50:07AM +0200, Uros Bizjak wrote: > > 2018-05-02 Jakub Jelinek > > > > PR target/85582 > > * config/i386/i386.md (*ashl3_doubleword_mask, > > *ashl3_doubleword_mask_1, *3_doubleword_mask, > > *3_doubleword_mask_1): If and[sq]i3 is needed

Re: [PATCH] Fix the x86 *_doubleword_mask* patterns (PR target/85582)

2018-05-02 Thread Uros Bizjak
On Wed, May 2, 2018 at 9:42 AM, Jakub Jelinek wrote: > Hi! > > operands[2] is an input operand in these define_insn_and_split patterns, > so when the masking needs to be still performed, we shouldn't modify that > input register; all the patterns are guarded with can_create_pseudo_p, > so we can c

[PATCH] Fix the x86 *_doubleword_mask* patterns (PR target/85582)

2018-05-02 Thread Jakub Jelinek
Hi! operands[2] is an input operand in these define_insn_and_split patterns, so when the masking needs to be still performed, we shouldn't modify that input register; all the patterns are guarded with can_create_pseudo_p, so we can create new pseudos there. Bootstrapped/regtested on x86_64-linux