Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-28 Thread Richard Biener
On Fri, Nov 28, 2014 at 12:45 AM, Ilya Verbin wrote: > On 27 Nov 16:00, Richard Biener wrote: >> On Thu, Nov 27, 2014 at 2:31 PM, Ilya Verbin wrote: >> > On 25 Nov 10:51, Richard Biener wrote: >> >> In the patch adding flag_generate_offload sounds like a good solution, >> >> I didn't like emittin

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-27 Thread Ilya Verbin
On 27 Nov 16:00, Richard Biener wrote: > On Thu, Nov 27, 2014 at 2:31 PM, Ilya Verbin wrote: > > On 25 Nov 10:51, Richard Biener wrote: > >> In the patch adding flag_generate_offload sounds like a good solution, > >> I didn't like emitting fat LTO objects unconditionally just because we > >> offl

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-27 Thread Richard Biener
On Thu, Nov 27, 2014 at 2:31 PM, Ilya Verbin wrote: > On 25 Nov 10:51, Richard Biener wrote: >> In the patch adding flag_generate_offload sounds like a good solution, >> I didn't like emitting fat LTO objects unconditionally just because we >> offload. > > Here is updated patch. Bootstrap and ma

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-27 Thread Ilya Verbin
On 25 Nov 10:51, Richard Biener wrote: > In the patch adding flag_generate_offload sounds like a good solution, > I didn't like emitting fat LTO objects unconditionally just because we > offload. Here is updated patch. Bootstrap and make check passed on i686-linux and x86_64-linux. Tests with o

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-25 Thread Richard Biener
On Mon, Nov 24, 2014 at 5:44 PM, Ilya Verbin wrote: > On 17 Nov 10:57, Richard Biener wrote: >> On Fri, Nov 14, 2014 at 6:08 PM, Ilya Verbin wrote: >> > On 14 Nov 09:01, H.J. Lu wrote: >> >> On Fri, Nov 14, 2014 at 8:51 AM, Ilya Verbin wrote: >> >> > On 14 Nov 08:46, H.J. Lu wrote: >> >> >> What

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-24 Thread Ilya Verbin
On 17 Nov 10:57, Richard Biener wrote: > On Fri, Nov 14, 2014 at 6:08 PM, Ilya Verbin wrote: > > On 14 Nov 09:01, H.J. Lu wrote: > >> On Fri, Nov 14, 2014 at 8:51 AM, Ilya Verbin wrote: > >> > On 14 Nov 08:46, H.J. Lu wrote: > >> >> What happens when -flto is used on command line? Will we > >> >

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-17 Thread Richard Biener
On Fri, Nov 14, 2014 at 6:08 PM, Ilya Verbin wrote: > On 14 Nov 09:01, H.J. Lu wrote: >> On Fri, Nov 14, 2014 at 8:51 AM, Ilya Verbin wrote: >> > On 14 Nov 08:46, H.J. Lu wrote: >> >> What happens when -flto is used on command line? Will we >> >> generate both LTO IR and offload IR? >> > >> > Ri

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-14 Thread Ilya Verbin
On 14 Nov 09:11, H.J. Lu wrote: > On Fri, Nov 14, 2014 at 9:08 AM, Ilya Verbin wrote: > > On 14 Nov 09:01, H.J. Lu wrote: > >> On Fri, Nov 14, 2014 at 8:51 AM, Ilya Verbin wrote: > >> > On 14 Nov 08:46, H.J. Lu wrote: > >> >> What happens when -flto is used on command line? Will we > >> >> gener

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-14 Thread H.J. Lu
On Fri, Nov 14, 2014 at 9:08 AM, Ilya Verbin wrote: > On 14 Nov 09:01, H.J. Lu wrote: >> On Fri, Nov 14, 2014 at 8:51 AM, Ilya Verbin wrote: >> > On 14 Nov 08:46, H.J. Lu wrote: >> >> What happens when -flto is used on command line? Will we >> >> generate both LTO IR and offload IR? >> > >> > Ri

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-14 Thread Ilya Verbin
On 14 Nov 09:01, H.J. Lu wrote: > On Fri, Nov 14, 2014 at 8:51 AM, Ilya Verbin wrote: > > On 14 Nov 08:46, H.J. Lu wrote: > >> What happens when -flto is used on command line? Will we > >> generate both LTO IR and offload IR? > > > > Right. > > > > I'm not sure whether we should make slim objects

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-14 Thread H.J. Lu
On Fri, Nov 14, 2014 at 8:51 AM, Ilya Verbin wrote: > On 14 Nov 08:46, H.J. Lu wrote: >> What happens when -flto is used on command line? Will we >> generate both LTO IR and offload IR? > > Right. > > I'm not sure whether we should make slim objects in case of LTO + offload > IR... > Isn't __gn

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-14 Thread Ilya Verbin
On 14 Nov 08:46, H.J. Lu wrote: > What happens when -flto is used on command line? Will we > generate both LTO IR and offload IR? Right. I'm not sure whether we should make slim objects in case of LTO + offload IR... -- Ilya

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-14 Thread H.J. Lu
On Fri, Nov 14, 2014 at 8:07 AM, Ilya Verbin wrote: > > > Hi, > > This patch fixes recent regressions in libgomp testsuite: > https://gcc.gnu.org/ml/gcc-regression/2014-11/msg00343.html > They are reproducible only with ld from trunk, ld 2.24 works fine. > > When GCC emits sections with offload I

[PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-14 Thread Ilya Verbin
Hi, This patch fixes recent regressions in libgomp testsuite: https://gcc.gnu.org/ml/gcc-regression/2014-11/msg00343.html They are reproducible only with ld from trunk, ld 2.24 works fine. When GCC emits sections with offload IR, it should not emit "__gnu_lto_slim" symbol, otherwise linker plug