Re: [PATCH] Fix profile count comparison.

2022-09-26 Thread Richard Biener via Gcc-patches
On Fri, Sep 23, 2022 at 8:53 PM Eugene Rozenfeld via Gcc-patches wrote: > > The comparison was incorrect when the counts weren't PRECISE. > For example, crossmodule-indir-call-topn-1.c was failing > with AutoFDO: when count_sum is 0 with quality AFDO, > count_sum > profile_count::zero() evaluates

[PATCH] Fix profile count comparison.

2022-09-23 Thread Eugene Rozenfeld via Gcc-patches
The comparison was incorrect when the counts weren't PRECISE. For example, crossmodule-indir-call-topn-1.c was failing with AutoFDO: when count_sum is 0 with quality AFDO, count_sum > profile_count::zero() evaluates to true. Taking that branch then leads to an assert in the call to to_sreal(). Tes