Re: [PATCH] Fix not properly nul-terminated string constants in JIT

2019-02-02 Thread Bernd Edlinger
Sorry, Dave, what should I do with this patch? Bernd. On 11/9/18 5:52 PM, Bernd Edlinger wrote: > Hi Dave, > > is the patch OK, or do you still have questions? > > > Thanks > Bernd. > > On 11/2/18 10:48 PM, Bernd Edlinger wrote: >> On 11/2/18 9:40 PM, David Malcolm wrote: >>> On Sun, 2018-0

Re: [PATCH] Fix not properly nul-terminated string constants in JIT

2018-11-09 Thread Bernd Edlinger
Hi Dave, is the patch OK, or do you still have questions? Thanks Bernd. On 11/2/18 10:48 PM, Bernd Edlinger wrote: > On 11/2/18 9:40 PM, David Malcolm wrote: >> On Sun, 2018-08-05 at 16:59 +, Bernd Edlinger wrote: >>> Hi! >>> >>> >>> My other patch with adds assertions to varasm.c regarding

Re: [PATCH] Fix not properly nul-terminated string constants in JIT

2018-11-02 Thread Bernd Edlinger
On 11/2/18 9:40 PM, David Malcolm wrote: > On Sun, 2018-08-05 at 16:59 +, Bernd Edlinger wrote: >> Hi! >> >> >> My other patch with adds assertions to varasm.c regarding correct >> nul termination of sting literals did make these incorrect string >> constants in JIT frontend fail. >> >> The str

Re: [PATCH] Fix not properly nul-terminated string constants in JIT

2018-11-02 Thread David Malcolm
On Sun, 2018-08-05 at 16:59 +, Bernd Edlinger wrote: > Hi! > > > My other patch with adds assertions to varasm.c regarding correct > nul termination of sting literals did make these incorrect string > constants in JIT frontend fail. > > The string constants are not nul terminated if their le

[PING**3] [PATCH] Fix not properly nul-terminated string constants in JIT

2018-11-01 Thread Bernd Edlinger
Ping... On 10/10/18 9:43 PM, Bernd Edlinger wrote: > Ping... > > > On 08/26/18 21:40, Bernd Edlinger wrote: >> Ping... >> >> This is just plain wrong, independent >> of any STRING_CST semantic issues. >> >> The original patch (retested on current trunk) is >> here: https://gcc.gnu.org/ml/gcc-pat

[PING**2] [PATCH] Fix not properly nul-terminated string constants in JIT

2018-10-10 Thread Bernd Edlinger
Ping... On 08/26/18 21:40, Bernd Edlinger wrote: > Ping... > > This is just plain wrong, independent > of any STRING_CST semantic issues. > > The original patch (retested on current trunk) is > here: https://gcc.gnu.org/ml/gcc-patches/2018-08/msg00370.html > > > On 08/05/18 18:59, Bernd Edlin

[PING] [PATCH] Fix not properly nul-terminated string constants in JIT

2018-08-26 Thread Bernd Edlinger
Ping... This is just plain wrong, independent of any STRING_CST semantic issues. The original patch (retested on current trunk) is here: https://gcc.gnu.org/ml/gcc-patches/2018-08/msg00370.html On 08/05/18 18:59, Bernd Edlinger wrote: > Hi! > > > My other patch with adds assertions to varasm.

[PATCH] Fix not properly nul-terminated string constants in JIT

2018-08-05 Thread Bernd Edlinger
Hi! My other patch with adds assertions to varasm.c regarding correct nul termination of sting literals did make these incorrect string constants in JIT frontend fail. The string constants are not nul terminated if their length exceeds 200 characters. The test cases do not use strings of that s