Re: [PATCH] Fix libstdc++ testsuite to handle VxWorks gthreads implementation

2020-08-25 Thread Jonathan Wakely via Gcc-patches
On 24/08/20 23:19 -0300, Alexandre Oliva wrote: On Aug 24, 2020, Jonathan Wakely wrote: OK for trunk, thanks. Given the approval and the lack of significant changes, I'll put this in unless there are objections in the next 48 hours. Thanks for the review! Thanks. There's a new FAIL due

Re: [PATCH] Fix libstdc++ testsuite to handle VxWorks gthreads implementation

2020-08-24 Thread Alexandre Oliva
On Aug 24, 2020, Jonathan Wakely wrote: >>> OK for trunk, thanks. >> Given the approval and the lack of significant changes, I'll put this in >> unless there are objections in the next 48 hours. Thanks for the review! > Thanks. There's a new FAIL due to a bad merge. Erhm... Weird, I don't re

Re: [PATCH] Fix libstdc++ testsuite to handle VxWorks gthreads implementation

2020-08-24 Thread Jonathan Wakely via Gcc-patches
On 21/08/20 09:37 -0300, Alexandre Oliva wrote: On Dec 20, 2019, Jonathan Wakely wrote: On 10/12/19 15:58 +0100, Corentin Gay wrote: This patch was tested on x86_64-linux and is part of our nightly testing on all platforms, including VxWorks. Was it tested on AIX? I think dg-require-gth

Re: [PATCH] Fix libstdc++ testsuite to handle VxWorks gthreads implementation

2020-08-21 Thread Alexandre Oliva
On Dec 20, 2019, Jonathan Wakely wrote: > On 10/12/19 15:58 +0100, Corentin Gay wrote: >> This patch was tested on x86_64-linux and is part of our nightly testing >> on all platforms, including VxWorks. > Was it tested on AIX? > I think dg-require-gthreads will prevent the tests running for the

Re: [PATCH] Fix libstdc++ testsuite to handle VxWorks gthreads implementation

2020-01-23 Thread Corentin Gay
On 20/12/2019 11:33, Jonathan Wakely wrote: Was it tested on AIX? I think dg-require-gthreads will prevent the tests running for the single-threaded multilib on AIX, so it will work OK. But there's a chance it will need fixing. Let's wait and see (I'm currently unable to build GCC on AIX).

Re: [PATCH] Fix libstdc++ testsuite to handle VxWorks gthreads implementation

2019-12-20 Thread Jonathan Wakely
On 10/12/19 15:58 +0100, Corentin Gay wrote: Hello there ! When implementing the support for gthreads in VxWorks, we stumbled on a problem in the testsuite. In the libstdc++ testsuite, we indiscriminately add the `-pthread` switch to the tests that require linking against the pthread library.

[PATCH] Fix libstdc++ testsuite to handle VxWorks gthreads implementation

2019-12-10 Thread Corentin Gay
Hello there ! When implementing the support for gthreads in VxWorks, we stumbled on a problem in the testsuite. In the libstdc++ testsuite, we indiscriminately add the `-pthread` switch to the tests that require linking against the pthread library. In certain cases, such as VxWorks, the gthrea