Re: [PATCH] Fix leak in splay-tree

2019-01-21 Thread Richard Biener
On Fri, Jan 18, 2019 at 10:27 PM Tom Tromey wrote: > > Philippe Waroquiers noticed a memory leak in gdb, which he tracked > down to a bug in splay-tree. splay_tree_remove does not call the > `delete_key' function when it removes the old node; but it should. > > I looked at every splay tree in GCC

[PATCH] Fix leak in splay-tree

2019-01-18 Thread Tom Tromey
Philippe Waroquiers noticed a memory leak in gdb, which he tracked down to a bug in splay-tree. splay_tree_remove does not call the `delete_key' function when it removes the old node; but it should. I looked at every splay tree in GCC and there is only one that passes a non-NULL delete function -