Re: [PATCH] Fix gimplification of ordering comparisons of arrays of bytes

2024-07-08 Thread Richard Biener
> Am 08.07.2024 um 16:39 schrieb Eric Botcazou : > >  >> >> IIRC at least some array of vector also have vector mode, I'm not sure >> type_for_mode is an INTEGER_TYPE in that case nor am I sure the max 128 >> bytes size holds here. > > Yes, array types may have vector modes. > >> There's al

Re: [PATCH] Fix gimplification of ordering comparisons of arrays of bytes

2024-07-08 Thread Eric Botcazou
> IIRC at least some array of vector also have vector mode, I'm not sure > type_for_mode is an INTEGER_TYPE in that case nor am I sure the max 128 > bytes size holds here. Yes, array types may have vector modes. > There's also array_mode_supported_p which can indicate larger modes are OK. Yes, b

Re: [PATCH] Fix gimplification of ordering comparisons of arrays of bytes

2024-07-08 Thread Richard Biener
On Mon, Jul 8, 2024 at 9:11 AM Eric Botcazou wrote: > > Hi, > > the Ada compiler now defers to the gimplifier for ordering comparisons of > arrays of bytes (Ada parlance for <, >, <= and >=) because the gimplifier in > turn defers to memcmp for them, which implements the required semantics. > > Ho

[PATCH] Fix gimplification of ordering comparisons of arrays of bytes

2024-07-08 Thread Eric Botcazou
Hi, the Ada compiler now defers to the gimplifier for ordering comparisons of arrays of bytes (Ada parlance for <, >, <= and >=) because the gimplifier in turn defers to memcmp for them, which implements the required semantics. However the gimplifier has a special processing for aggregate types