Re: [PATCH] Fix debug stmt handling in optimize_recip_sqrt (PR tree-optimization/87977)

2018-11-14 Thread Richard Biener
On Wed, 14 Nov 2018, Jakub Jelinek wrote: > On Tue, Nov 13, 2018 at 10:19:10AM +0100, Jakub Jelinek wrote: > > > > Though, in this particular case the sqrt call is > > > > optimized away, so it wouldn't make a difference. > > > > > > > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok

Re: [PATCH] Fix debug stmt handling in optimize_recip_sqrt (PR tree-optimization/87977)

2018-11-13 Thread Jakub Jelinek
On Tue, Nov 13, 2018 at 10:19:10AM +0100, Jakub Jelinek wrote: > > > Though, in this particular case the sqrt call is > > > optimized away, so it wouldn't make a difference. > > > > > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk, or > > > should I do the gimple_build_assi

Re: [PATCH] Fix debug stmt handling in optimize_recip_sqrt (PR tree-optimization/87977)

2018-11-13 Thread Jakub Jelinek
On Tue, Nov 13, 2018 at 10:04:03AM +0100, Richard Biener wrote: > On Tue, 13 Nov 2018, Jakub Jelinek wrote: > > > Hi! > > > > During analysis, we correctly ignore debug stmt uses, but if we don't > > release the ssa name we stopped using, the debug stmts uses are left in the > > IL. The reset_de

Re: [PATCH] Fix debug stmt handling in optimize_recip_sqrt (PR tree-optimization/87977)

2018-11-13 Thread Richard Biener
On Tue, 13 Nov 2018, Jakub Jelinek wrote: > Hi! > > During analysis, we correctly ignore debug stmt uses, but if we don't > release the ssa name we stopped using, the debug stmts uses are left in the > IL. The reset_debug_uses call is needed because the code modifies the > division stmt in place

[PATCH] Fix debug stmt handling in optimize_recip_sqrt (PR tree-optimization/87977)

2018-11-13 Thread Jakub Jelinek
Hi! During analysis, we correctly ignore debug stmt uses, but if we don't release the ssa name we stopped using, the debug stmts uses are left in the IL. The reset_debug_uses call is needed because the code modifies the division stmt in place. Perhaps better would be not to do that, i.e. create