Re: [PATCH] Fix combiner to create canonical CONST_INTs (PR rtl-optimization/53519)

2012-05-29 Thread Richard Sandiford
Jakub Jelinek writes: > 2012-05-30 Jakub Jelinek > > PR rtl-optimization/53519 > * combine.c (simplify_shift_const_1) : Use constm1_rtx > instead of GEN_INT (GET_MODE_MASK (mode)) as second operand of XOR. > > * gcc.c-torture/compile/pr53519.c: New test. OK, thanks. Ri

[PATCH] Fix combiner to create canonical CONST_INTs (PR rtl-optimization/53519)

2012-05-29 Thread Jakub Jelinek
Hi! GEN_INT (GET_MODE_MASK (mode)) isn't canonical CONST_INT for mode, because it is zero extended rather than sign-extended for GET_MODE_BITSIZE (mode) < HOST_BITS_PER_WIDE_INT modes. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2012-05-30 Jakub Jelinek